Skip to content

feat: enable TS autocomplete for Svelte HTML element definitions #15972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 23, 2025
Merged

feat: enable TS autocomplete for Svelte HTML element definitions #15972

merged 2 commits into from
May 23, 2025

Conversation

@ivenuss
Copy link
Contributor

@ivenuss ivenuss commented May 20, 2025

Covers #15971.

TL;DR: adds autocomplete support to SvelteHTMLElements while preserving its functionality that key can be any string using string & {} TS trick.

Demonstration

image
image

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot
Copy link

changeset-bot bot commented May 20, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3b6a0e4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svelte-docs-bot
Copy link

svelte-docs-bot bot commented May 20, 2025

Preview: https://svelte-dev-git-preview-svelte-15972-svelte.vercel.app/

@Rich-Harris Rich-Harris requested a review from dummdidumm May 21, 2025 01:36
@github-actions
Copy link
Contributor

github-actions bot commented May 21, 2025

Playground

pnpm add https://pkg.pr.new/svelte@15972

paoloricciuti
paoloricciuti approved these changes May 21, 2025
View reviewed changes
Copy link
Member

@paoloricciuti paoloricciuti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's wait for @dummdidumm too in case I'm missing something silly

dummdidumm
dummdidumm approved these changes May 23, 2025
View reviewed changes
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@dummdidumm dummdidumm merged commit 6928aac into sveltejs:main May 23, 2025
9 checks passed
@ivenuss ivenuss mentioned this pull request May 23, 2025
Closed
@ivenuss ivenuss deleted the ts-elements-autocomplete branch May 23, 2025 23:04
@rChaoz rChaoz mentioned this pull request May 31, 2025
Closed
@Rich-Harris Rich-Harris mentioned this pull request Jun 2, 2025
Merged
@Rich-Harris
Copy link
Member

Rich-Harris commented Jun 2, 2025

Unfortunately this change caused #16046 — opened #16063 to revert this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dummdidumm dummdidumm dummdidumm approved these changes

@paoloricciuti paoloricciuti paoloricciuti approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ivenuss @Rich-Harris @dummdidumm @paoloricciuti