Skip to content

fix: bind:value to select with stores #16028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2025
Merged

fix: bind:value to select with stores #16028

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8d58df
fix: `bind:value` to select with stores
paoloricciuti May 29, 2025
551437c
Update packages/svelte/src/compiler/phases/3-transform/server/visitor…
Rich-Harris May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/honest-crabs-try.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: `bind:value` to select with stores
2 changes: 1 addition & 1 deletion packages/svelte/src/compiler/phases/3-transform/server/visitors/RegularElement.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export function RegularElement(node, context) {
left,
value.expression.type === 'SequenceExpression'
? b.call(value.expression.expressions[0])
: value.expression
: /** @type {Expression} */ (context.visit(value.expression))
)
)
);
Expand Down
1 change: 1 addition & 0 deletions packages/svelte/tests/server-side-rendering/samples/select-value-bind-store/_expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<select><option value="">--Please choose an option--</option><option value="dog" selected>Dog</option><option value="cat">Cat</option></select>
10 changes: 10 additions & 0 deletions packages/svelte/tests/server-side-rendering/samples/select-value-bind-store/main.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<script>
import { writable } from 'svelte/store';
const value = writable('dog');
</script>

<select bind:value={$value}>
<option value="">--Please choose an option--</option>
<option value="dog">Dog</option>
<option value="cat">Cat</option>
</select>