Skip to content

chore: rename check_dirtiness -> is_dirty #16359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ocean-OS merged 1 commit into from
Jul 13, 2025
Merged

chore: rename check_dirtiness -> is_dirty #16359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/svelte/src/internal/client/reactivity/effects.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/** @import { ComponentContext, ComponentContextLegacy, Derived, Effect, TemplateNode, TransitionManager } from '#client' */
import {
check_dirtiness,
is_dirty,
active_effect,
active_reaction,
update_effect,
Expand Down Expand Up @@ -307,7 +307,7 @@ export function legacy_pre_effect_reset() {
set_signal_status(effect, MAYBE_DIRTY);
}

if (check_dirtiness(effect)) {
if (is_dirty(effect)) {
update_effect(effect);
}

Expand Down
4 changes: 2 additions & 2 deletions packages/svelte/src/internal/client/reactivity/sources.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {
increment_write_version,
update_effect,
current_sources,
check_dirtiness,
is_dirty,
untracking,
is_destroying_effect,
push_reaction_value
Expand Down Expand Up @@ -218,7 +218,7 @@ export function internal_set(source, value) {
if ((effect.f & CLEAN) !== 0) {
set_signal_status(effect, MAYBE_DIRTY);
}
if (check_dirtiness(effect)) {
if (is_dirty(effect)) {
update_effect(effect);
}
}
Expand Down
10 changes: 5 additions & 5 deletions packages/svelte/src/internal/client/runtime.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ export function increment_write_version() {
* @param {Reaction} reaction
* @returns {boolean}
*/
export function check_dirtiness(reaction) {
export function is_dirty(reaction) {
var flags = reaction.f;

if ((flags & DIRTY) !== 0) {
Expand Down Expand Up @@ -212,7 +212,7 @@ export function check_dirtiness(reaction) {
for (i = 0; i < length; i++) {
dependency = dependencies[i];

if (check_dirtiness(/** @type {Derived} */ (dependency))) {
if (is_dirty(/** @type {Derived} */ (dependency))) {
update_derived(/** @type {Derived} */ (dependency));
}

Expand Down Expand Up @@ -588,7 +588,7 @@ function flush_queued_effects(effects) {
var effect = effects[i];

if ((effect.f & (DESTROYED | INERT)) === 0) {
if (check_dirtiness(effect)) {
if (is_dirty(effect)) {
var wv = write_version;

update_effect(effect);
Expand Down Expand Up @@ -675,7 +675,7 @@ function process_effects(root) {
} else if (is_branch) {
effect.f ^= CLEAN;
} else {
if (check_dirtiness(effect)) {
if (is_dirty(effect)) {
update_effect(effect);
}
}
Expand Down Expand Up @@ -802,7 +802,7 @@ export function get(signal) {
if (is_derived && !is_destroying_effect) {
derived = /** @type {Derived} */ (signal);

if (check_dirtiness(derived)) {
if (is_dirty(derived)) {
update_derived(derived);
}
}
Expand Down
Loading