Skip to content

Commit 1abb517

Browse files
committed
add testcase with nested workspace devdep
1 parent b74031a commit 1abb517

File tree

6 files changed

+72
-3
lines changed

6 files changed

+72
-3
lines changed
Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
{
2+
"version": "1.0.0",
3+
"private": true,
4+
"name": "e2e-test-dep-svelte-nested-workspace-devdep",
5+
"svelte": "src/index.js",
6+
"main": "src/index.js",
7+
"type": "module",
8+
"files": [
9+
"src"
10+
],
11+
"exports": {
12+
"./package.json": "./package.json",
13+
".": {
14+
"import": {
15+
"svelte": "./src/index.js"
16+
}
17+
}
18+
},
19+
"devDependencies": {
20+
"e2e-test-dep-svelte-simple": "workspace:*",
21+
"e2e-test-dep-cjs-and-esm": "workspace:*",
22+
"e2e-test-dep-scss-only": "workspace:*"
23+
}
24+
}
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
<script>
2+
export let id = 'id';
3+
export let message = '';
4+
import { cjs_and_esm } from 'e2e-test-dep-cjs-and-esm';
5+
import 'e2e-test-dep-scss-only';
6+
</script>
7+
8+
<div {id}>{message}</div>
9+
<div id="cjs-and-esm">{cjs_and_esm()}</div>
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
import Message from './components/Message.svelte';
2+
export { Message };

packages/e2e-tests/kit-node/__tests__/kit.spec.ts

Lines changed: 21 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,10 @@ describe('kit-node', () => {
292292
'cli-color',
293293
'tiny-glob',
294294
'cookie',
295-
'set-cookie-parser'
295+
'set-cookie-parser',
296+
'e2e-test-dep-cjs-and-esm',
297+
'e2e-test-dep-cjs-only',
298+
'e2e-test-dep-scss-only'
296299
]
297300
: [],
298301
`ssr.external in ${filename}`
@@ -307,13 +310,22 @@ describe('kit-node', () => {
307310
'esm-env', // first added by svelte-kit
308311
'esm-env', // second added by vite-plugin-svelte
309312
'@sveltejs/kit',
310-
'@sveltejs/adapter-node'
313+
'@sveltejs/adapter-node',
314+
'e2e-test-dep-svelte-nested-workspace-devdep',
315+
'e2e-test-dep-svelte-simple'
311316
],
312317
`ssr.noExternal in ${filename}`
313318
);
319+
const expectedExcludes = ['@sveltejs/kit', '$app', '$env'];
320+
if (!isServe) {
321+
expectedExcludes.push(
322+
'e2e-test-dep-svelte-nested-workspace-devdep',
323+
'e2e-test-dep-svelte-simple'
324+
);
325+
}
314326
expectArrayEqual(
315327
config.optimizeDeps.exclude,
316-
['@sveltejs/kit', '$app', '$env'],
328+
expectedExcludes,
317329
`optimizeDeps.exclude in ${filename}`
318330
);
319331
let expectedIncludes = [
@@ -345,6 +357,12 @@ describe('kit-node', () => {
345357
(item) => !(isServe && item.startsWith('svelte-i18n >'))
346358
);
347359

360+
if (!isServe) {
361+
expectedIncludes.push(
362+
'e2e-test-dep-svelte-nested-workspace-devdep > e2e-test-dep-svelte-simple > e2e-test-dep-cjs-only'
363+
);
364+
}
365+
348366
expectArrayEqual(
349367
config.optimizeDeps.include,
350368
expectedIncludes,

packages/e2e-tests/kit-node/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
"@sveltejs/vite-plugin-svelte": "workspace:^",
1818
"e2e-test-dep-svelte-api-only": "file:../_test_dependencies/svelte-api-only",
1919
"e2e-test-dep-vite-plugins": "file:../_test_dependencies/vite-plugins",
20+
"e2e-test-dep-svelte-nested-workspace-devdep": "workspace:*",
2021
"svelte": "^5.34.9",
2122
"svelte-check": "^4.2.2",
2223
"svelte-i18n": "^4.0.1",

pnpm-lock.yaml

Lines changed: 15 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)