Skip to content

Commit 22a04bc

Browse files
committed
add warning log if inlineConst is disabled
1 parent 9843803 commit 22a04bc

File tree

1 file changed

+11
-8
lines changed

1 file changed

+11
-8
lines changed

packages/vite-plugin-svelte/src/plugins/configure.js

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -70,20 +70,23 @@ export function configure(api, inlineOptions) {
7070
//@ts-ignore rolldownOptions only exists in rolldown-vite
7171
extraViteConfig.build.rolldownOptions = extraViteConfig.build.rollupOptions || {};
7272
delete extraViteConfig.build.rollupOptions;
73-
74-
// set inlineConst
75-
// TODO is `inlineConst: "safe"` safe to use with esm-env (we have to ensure it is always inlined)
76-
if (
73+
// read user config inlineConst value
74+
const inlineConst =
7775
//@ts-ignore optimization only exists in rolldown-vite
78-
config.build?.rollupOptions?.optimization?.inlineConst == null &&
79-
//@ts-ignore rolldownOptions only exists in rolldown-vite
80-
config.build?.rolldownOptions?.optimization?.inlineConst == null
81-
) {
76+
config.build?.rolldownOptions?.optimization?.inlineConst ??
77+
//@ts-ignore optimization only exists in rolldown-vite
78+
config.build?.rollupOptions?.optimization?.inlineConst;
79+
80+
if (inlineConst == null) {
8281
// set inlineConst build optimization for esm-env
8382
//@ts-ignore rolldownOptions only exists in rolldown-vite
8483
extraViteConfig.build.rolldownOptions.optimization ??= {};
8584
//@ts-ignore rolldownOptions only exists in rolldown-vite
8685
extraViteConfig.build.rolldownOptions.optimization.inlineConst = true;
86+
} else if (inlineConst === false) {
87+
log.warn(
88+
'Your rolldown config contains `optimization.inlineConst: false`. This can lead to increased bundle size and leaked server code in client build.'
89+
);
8790
}
8891
}
8992
}

0 commit comments

Comments
 (0)