Skip to content

Commit 2484e0e

Browse files
authored
fix: prevent errors in resolveViaPackageJsonSvelte breaking vite resolve (#286)
1 parent d7dfac9 commit 2484e0e

File tree

2 files changed

+18
-5
lines changed

2 files changed

+18
-5
lines changed

.changeset/smooth-bananas-yawn.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@sveltejs/vite-plugin-svelte': patch
3+
---
4+
5+
prevent errors in resolveViaPackageJsonSvelte breaking vite resolve (fixes #283)

packages/vite-plugin-svelte/src/index.ts

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -134,11 +134,19 @@ export function svelte(inlineOptions?: Partial<Options>): Plugin {
134134
}
135135
return resolvedSvelteSSR;
136136
}
137-
138-
const resolved = resolveViaPackageJsonSvelte(importee, importer, cache);
139-
if (resolved) {
140-
log.debug(`resolveId resolved ${resolved} via package.json svelte field of ${importee}`);
141-
return resolved;
137+
try {
138+
const resolved = resolveViaPackageJsonSvelte(importee, importer, cache);
139+
if (resolved) {
140+
log.debug(`resolveId resolved ${resolved} via package.json svelte field of ${importee}`);
141+
return resolved;
142+
}
143+
} catch (e) {
144+
log.debug.once(
145+
`error trying to resolve ${importee} from ${importer} via package.json svelte field `,
146+
e
147+
);
148+
// this error most likely happens due to non-svelte related importee/importers so swallow it here
149+
// in case it really way a svelte library, users will notice anyway. (lib not working due to failed resolve)
142150
}
143151
},
144152

0 commit comments

Comments
 (0)