Skip to content

Commit 4decc2d

Browse files
committed
fix: update warning codes for svelte5
1 parent 1b302f1 commit 4decc2d

File tree

4 files changed

+9
-3
lines changed

4 files changed

+9
-3
lines changed

.changeset/eleven-pears-compare.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@sveltejs/vite-plugin-svelte': patch
3+
---
4+
5+
use correct warning code to hide unused css selector warning coming from vite-plugin-svelte injected code during development

packages/e2e-tests/import-queries/svelte.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ export default {
44
preprocess: [vitePreprocess()],
55
onwarn(warning, defaultHandler) {
66
// import query test generates one of these
7-
if (warning.code === 'custom-element-no-tag') return;
7+
if (warning.code === 'options_missing_custom_element') return;
88
defaultHandler(warning);
99
}
1010
};

packages/vite-plugin-svelte/src/utils/error.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,7 @@ export function enhanceCompileError(err, originalCode, preprocessors) {
114114

115115
// Handle incorrect CSS preprocessor usage
116116
if (err.code === 'css-syntax-error') {
117+
// TODO find the correct new code or new way to identify css syntax error
117118
// Reference from Svelte: https://github.com/sveltejs/svelte/blob/9926347ad9dbdd0f3324d5538e25dcb7f5e442f8/packages/svelte/src/compiler/preprocess/index.js#L257
118119
const styleRe =
119120
/<!--[^]*?-->|<style((?:\s+[^=>'"/]+=(?:"[^"]*"|'[^']*'|[^>\s]+)|\s+[^=>'"/]+)*\s*)(?:\/>|>([\S\s]*?)<\/style>)/g;

packages/vite-plugin-svelte/src/utils/log.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ export function logCompilerWarnings(svelteRequest, warnings, options) {
182182
*/
183183
function ignoreCompilerWarning(warning, isBuild, emitCss) {
184184
return (
185-
(!emitCss && warning.code === 'css-unused-selector') || // same as rollup-plugin-svelte
185+
(!emitCss && warning.code === 'css_unused_selector') || // same as rollup-plugin-svelte
186186
(!isBuild && isNoScopableElementWarning(warning))
187187
);
188188
}
@@ -194,7 +194,7 @@ function ignoreCompilerWarning(warning, isBuild, emitCss) {
194194
*/
195195
function isNoScopableElementWarning(warning) {
196196
// see https://github.com/sveltejs/vite-plugin-svelte/issues/153
197-
return warning.code === 'css-unused-selector' && warning.message.includes('"*"');
197+
return warning.code === 'css_unused_selector' && warning.message.includes('"*"');
198198
}
199199

200200
/**

0 commit comments

Comments
 (0)