fix: support comparing partial version strings (missing tag,patch,minor)

Author: dominikg

packages/vite-plugin-svelte/__tests__/svelte-version.spec.js

@@ -5,28 +5,51 @@ describe('gte', () => {
 	it('returns false for smaller tag', () => {
 		expect(gte('1.2.3-next.1', '1.2.3-next.2')).toBe(false);
 	});
+	it('returns false for tag vs no tag', () => {
+		expect(gte('1.2.3-next.0', '1.2.3')).toBe(false);
+	});
 	it('returns false for smaller patch', () => {
+		expect(gte('1.2.2-next.0', '1.2.3')).toBe(false);
 		expect(gte('1.2.2', '1.2.3')).toBe(false);
 	});
 	it('returns false for smaller minor', () => {
+		expect(gte('1.1.4-next.0', '1.2.3')).toBe(false);
 		expect(gte('1.1.4', '1.2.3')).toBe(false);
+		expect(gte('1.1', '1.2.3')).toBe(false);
 	});
 	it('returns false for smaller major', () => {
+		expect(gte('0.3.4-next.0', '1.2.3')).toBe(false);
 		expect(gte('0.3.4', '1.2.3')).toBe(false);
+		expect(gte('0.3', '1.2.3')).toBe(false);
+		expect(gte('0', '1.2.3')).toBe(false);
 	});
 	it('returns true for equal', () => {
 		expect(gte('1.2.3-next.1', '1.2.3-next.1')).toBe(true);
 	});
-	it('returns false for larger tag', () => {
+	it('returns true for equal without tag', () => {
+		expect(gte('1.2.3', '1.2.3')).toBe(true);
+		expect(gte('1.2', '1.2.0')).toBe(true);
+		expect(gte('1.2', '1.2')).toBe(true);
+		expect(gte('1', '1.0')).toBe(true);
+		expect(gte('1', '1.0.0')).toBe(true);
+	});
+	it('returns true for larger tag', () => {
 		expect(gte('1.2.3-next.2', '1.2.3-next.1')).toBe(true);
 	});
+	it('returns true for no tag vs tag', () => {
+		expect(gte('1.2.3', '1.2.3-next.0')).toBe(true);
+	});
 	it('returns true for larger patch', () => {
 		expect(gte('1.2.4', '1.2.3')).toBe(true);
+		expect(gte('1.2.4-next.0', '1.2.3')).toBe(true);
 	});
 	it('returns true for larger minor', () => {
 		expect(gte('1.3.1', '1.2.3')).toBe(true);
+		expect(gte('1.3', '1.2.3')).toBe(true);
 	});
 	it('returns true for larger major', () => {
 		expect(gte('2.0.0', '1.2.3')).toBe(true);
+		expect(gte('2.0', '1.2.3')).toBe(true);
+		expect(gte('2', '1.2.3')).toBe(true);
 	});
 });

packages/vite-plugin-svelte/src/utils/svelte-version.js

@@ -11,10 +11,17 @@ export const isSvelteWithAsync = gte(VERSION, '5.36.0');
  * @return {number[]} [major,minor,patch,tag]
  */
 function splitToNumbers(semver) {
-	return semver
+	const num = semver
 		.replace(/[^\d.-]/g, '')
 		.split(/[.-]+/, 4)
 		.map(Number);
+	while (num.length < 3) {
+		num.push(0);
+	}
+	if (num.length < 4) {
+		num.push(Infinity);
+	}
+	return num;
 }
 
 /**