Skip to content

Commit 54fa669

Browse files
authored
chore(actions): harden release action and clean up ci (#966)
1 parent 819f8e2 commit 54fa669

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ jobs:
9898
cache: 'pnpm'
9999
cache-dependency-path: '**/pnpm-lock.yaml'
100100
- name: install
101-
run: pnpm install --frozen-lockfile --prefer-offline --ignore-scripts
101+
run: pnpm install --frozen-lockfile --ignore-scripts
102102
- name: install playwright chromium
103103
run: pnpm playwright install chromium
104104
- name: run tests

.github/workflows/release.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -56,17 +56,17 @@ jobs:
5656
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
5757
- name: Create Release Pull Request or Publish to npm
5858
id: changesets
59-
uses: changesets/action@v1
59+
# pinned for security, always review third party action code before updating
60+
uses: changesets/action@aba318e9165b45b7948c60273e0b72fce0a64eb9 #v1.4.7
6061
with:
6162
# This expects you to have a script called release which does a build for your packages and calls changeset publish
6263
publish: pnpm release
6364
env:
6465
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
6566
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
6667
NPM_CONFIG_PROVENANCE: true
67-
68-
# TODO alert discord
69-
# - name: Send a Slack notification if a publish happens
70-
# if: steps.changesets.outputs.published == 'true'
71-
# # You can do something when a publish happens.
72-
# run: my-slack-bot send-notification --message "A new version of ${GITHUB_REPOSITORY} was published!"
68+
- name: Remove .npmrc
69+
if: always()
70+
run: |
71+
echo "#deleted" > "$HOME/.npmrc"
72+
rm -f "$HOME/.npmrc"

0 commit comments

Comments
 (0)