Skip to content

Commit 6c79960

Browse files
authored
test: add small wait for inspector icon to become visible (#654)
* test: add small wait for inspector icon to become visible to avoid flakiness in tests * fix: increase wait on CI
1 parent abce5b9 commit 6c79960

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

packages/e2e-tests/inspector-kit/__tests__/inspector.kit.spec.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
1-
import { getEl, getText, isBuild, page } from '~utils';
1+
import { getEl, getText, isBuild, page, isCI } from '~utils';
22

33
describe('inspector-kit', () => {
44
it('should render page', async () => {
55
expect(await getText('h1')).toBe('Hello Inspector!');
66
});
77
if (!isBuild) {
88
it('should show inspector toggle during dev', async () => {
9-
await page.waitForLoadState('networkidle');
9+
await page
10+
.locator('#svelte-inspector-toggle')
11+
.waitFor({ state: 'visible', timeout: isCI ? 2000 : 500 });
1012
expect(await getEl('#svelte-inspector-toggle')).not.toBe(null);
1113
});
1214
} else {

packages/e2e-tests/inspector-vite/__tests__/inspector.vite.spec.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,14 @@
1-
import { getEl, getText, isBuild } from '~utils';
1+
import { getEl, getText, isBuild, page, isCI } from '~utils';
22

33
describe('inspector-vite', () => {
44
it('should render page', async () => {
55
expect(await getText('h1')).toBe('Hello Inspector!');
66
});
77
if (!isBuild) {
88
it('should show inspector toggle during dev', async () => {
9+
await page
10+
.locator('#svelte-inspector-toggle')
11+
.waitFor({ state: 'visible', timeout: isCI ? 2000 : 500 });
912
expect(await getEl('#svelte-inspector-toggle')).not.toBe(null);
1013
});
1114
} else {

0 commit comments

Comments
 (0)