wip: add svelte version check for async and use it in kit-node test

dominikg · dominikg · commit d1fc2d3d3e9b · 2025-07-15T13:05:00.000+02:00
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -77,21 +77,26 @@ jobs:
         node: [22]
         os: [ubuntu-latest, macos-latest, windows-latest]
         vite: ['current']
+        svelte: ['current']
         include:
           - node: 20
             os: ubuntu-latest
             vite: 'current'
+            svelte: 'current'
           - node: 24
             os: ubuntu-latest
             vite: 'current'
-          # baseline test lowest vite and node version
+            svelte: 'current'
+          # baseline test lowest svelte, vite and node version
           - node: 20.19
             os: ubuntu-latest
             vite: 'baseline'
+            svelte: 'baseline'
           # future test with rolldown-vite
           - node: 24
             os: ubuntu-latest
-            vite: 'rolldown-vite'
+            vite: 'rolldown-vite',
+            svelte: 'current'
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
@@ -115,6 +120,11 @@ jobs:
         run: |
           pnpm update -r --no-save vite@6.3.0
           pnpm ls vite
+      - name: downgrade svelte to baseline
+        if: matrix.svelte == 'baseline'
+        run: |
+          pnpm update -r --no-save svelte@5.0.0
+          pnpm ls svelte
       - name: update vite to rolldown-vite
         if: matrix.vite == 'rolldown-vite'
         run: |
@@ -134,7 +144,7 @@ jobs:
       - uses: actions/upload-artifact@v4
         if: failure()
         with:
-          name: test-failure-${{github.run_id}}-${{ matrix.os }}-${{ matrix.node }}-${{ matrix.vite }}
+          name: test-failure-${{github.run_id}}-os_${{ matrix.os }}-node_${{ matrix.node }}-vite_${{ matrix.vite }}-svelte_${{matrix.svelte}}
           path: |
             test-temp.tar
             pnpm-debug.log
diff --git a/package.json b/package.json
@@ -28,7 +28,7 @@
     "@eslint/js": "^9.30.1",
     "@stylistic/eslint-plugin-js": "^4.4.1",
     "@sveltejs/eslint-config": "^8.2.0",
-    "@sveltejs/kit": "^2.22.5",
+    "@sveltejs/kit": "^2.23.0",
     "@svitejs/changesets-changelog-github-compact": "^1.2.0",
     "@types/fs-extra": "^11.0.4",
     "@types/node": "^22.16.0",
@@ -51,7 +51,7 @@
     "prettier": "^3.6.2",
     "prettier-plugin-svelte": "^3.4.0",
     "publint": "^0.3.12",
-    "svelte": "^5.35.2",
+    "svelte": "^5.36.0",
     "svelte-eslint-parser": "^1.2.0",
     "typescript": "^5.8.3",
     "typescript-eslint": "^8.35.1",
diff --git a/packages/e2e-tests/_test_dependencies/svelte-api-only/package.json b/packages/e2e-tests/_test_dependencies/svelte-api-only/package.json
@@ -15,6 +15,6 @@
   },
   "type": "module",
   "dependencies": {
-    "svelte": "^5.35.2"
+    "svelte": "^5.36.0"
   }
 }
diff --git a/packages/e2e-tests/autoprefixer-browerslist/package.json b/packages/e2e-tests/autoprefixer-browerslist/package.json
@@ -15,7 +15,7 @@
     "autoprefixer": "^10.4.21",
     "postcss": "^8.5.6",
     "postcss-load-config": "^6.0.1",
-    "svelte": "^5.35.2",
+    "svelte": "^5.36.0",
     "svelte-preprocess": "^6.0.3",
     "vite": "^7.0.2"
   },
diff --git a/packages/e2e-tests/configfile-custom/package.json b/packages/e2e-tests/configfile-custom/package.json
@@ -12,7 +12,7 @@
   },
   "devDependencies": {
     "@sveltejs/vite-plugin-svelte": "workspace:^",
-    "svelte": "^5.35.2",
+    "svelte": "^5.36.0",
     "vite": "^7.0.2"
   },
   "type": "module"
diff --git a/packages/e2e-tests/configfile-esm/package.json b/packages/e2e-tests/configfile-esm/package.json
@@ -12,7 +12,7 @@
   },
   "devDependencies": {
     "@sveltejs/vite-plugin-svelte": "workspace:^",
-    "svelte": "^5.35.2",
+    "svelte": "^5.36.0",
     "svelte-preprocess": "^6.0.3",
     "vite": "^7.0.2"
   },
diff --git a/packages/e2e-tests/css-dev-sourcemap/package.json b/packages/e2e-tests/css-dev-sourcemap/package.json
@@ -11,7 +11,7 @@
   "devDependencies": {
     "@sveltejs/vite-plugin-svelte": "workspace:^",
     "sass": "^1.89.2",
-    "svelte": "^5.35.2",
+    "svelte": "^5.36.0",
     "vite": "^7.0.2"
   }
 }
diff --git a/packages/e2e-tests/css-treeshake/package.json b/packages/e2e-tests/css-treeshake/package.json
@@ -11,7 +11,7 @@
   "devDependencies": {
     "@sveltejs/vite-plugin-svelte": "workspace:^",
     "sass": "^1.89.2",
-    "svelte": "^5.35.2",
+    "svelte": "^5.36.0",
     "vite": "^7.0.2"
   }
 }
diff --git a/packages/e2e-tests/custom-extensions/package.json b/packages/e2e-tests/custom-extensions/package.json
@@ -9,7 +9,7 @@
   },
   "devDependencies": {
     "@sveltejs/vite-plugin-svelte": "workspace:^",
-    "svelte": "^5.35.2",
+    "svelte": "^5.36.0",
     "vite": "^7.0.2"
   },
   "type": "module"
diff --git a/packages/e2e-tests/dynamic-compile-options/package.json b/packages/e2e-tests/dynamic-compile-options/package.json
@@ -9,7 +9,7 @@
   },
   "devDependencies": {
     "@sveltejs/vite-plugin-svelte": "workspace:^",
-    "svelte": "^5.35.2",
+    "svelte": "^5.36.0",
     "vite": "^7.0.2"
   },
   "type": "module"
diff --git a/packages/e2e-tests/env/package.json b/packages/e2e-tests/env/package.json
@@ -9,7 +9,7 @@
   },
   "devDependencies": {
     "@sveltejs/vite-plugin-svelte": "workspace:^",
-    "svelte": "^5.35.2",
+    "svelte": "^5.36.0",
     "vite": "^7.0.2"
   },
   "type": "module"
diff --git a/packages/e2e-tests/hmr/package.json b/packages/e2e-tests/hmr/package.json
@@ -14,7 +14,7 @@
     "@sveltejs/vite-plugin-svelte": "workspace:^",
     "e2e-test-dep-vite-plugins": "file:../_test_dependencies/vite-plugins",
     "node-fetch": "^3.3.2",
-    "svelte": "^5.35.2",
+    "svelte": "^5.36.0",
     "vite": "^7.0.2"
   },
   "type": "module"
diff --git a/packages/e2e-tests/import-queries/package.json b/packages/e2e-tests/import-queries/package.json
@@ -11,7 +11,7 @@
   "devDependencies": {
     "@sveltejs/vite-plugin-svelte": "workspace:^",
     "sass": "^1.89.2",
-    "svelte": "^5.35.2",
+    "svelte": "^5.36.0",
     "vite": "^7.0.2"
   }
 }
diff --git a/packages/e2e-tests/inspector-kit/package.json b/packages/e2e-tests/inspector-kit/package.json
@@ -10,7 +10,7 @@
   "devDependencies": {
     "@sveltejs/kit": "^2.22.2",
     "@sveltejs/vite-plugin-svelte": "workspace:^",
-    "svelte": "^5.35.2",
+    "svelte": "^5.36.0",
     "vite": "^7.0.2"
   },
   "type": "module"
diff --git a/packages/e2e-tests/inspector-vite/package.json b/packages/e2e-tests/inspector-vite/package.json
@@ -10,7 +10,7 @@
   },
   "devDependencies": {
     "@sveltejs/vite-plugin-svelte": "workspace:^",
-    "svelte": "^5.35.2",
+    "svelte": "^5.36.0",
     "vite": "^7.0.2"
   }
 }
diff --git a/packages/e2e-tests/kit-node/__tests__/kit.spec.ts b/packages/e2e-tests/kit-node/__tests__/kit.spec.ts
@@ -344,6 +344,7 @@ describe('kit-node', () => {
 					'svelte',
 					'svelte > clsx',
 					'svelte/internal/disclose-version',
+					'svelte/internal/flags/async',
 					'svelte/internal/flags/legacy',
 					'svelte/internal/flags/tracing',
 					'svelte/legacy',
@@ -381,6 +382,7 @@ describe('kit-node', () => {
 					'svelte/transition',
 					'svelte',
 					'svelte/internal/disclose-version',
+					'svelte/internal/flags/async',
 					'svelte/internal/flags/legacy',
 					'svelte/internal/flags/tracing',
 					'svelte/internal/server',
diff --git a/packages/e2e-tests/kit-node/package.json b/packages/e2e-tests/kit-node/package.json
@@ -18,7 +18,7 @@
     "e2e-test-dep-svelte-api-only": "file:../_test_dependencies/svelte-api-only",
     "e2e-test-dep-vite-plugins": "file:../_test_dependencies/vite-plugins",
     "e2e-test-dep-svelte-nested-workspace-devdep": "../_test_dependencies/svelte-nested-workspace-devdep",
-    "svelte": "^5.35.2",
+    "svelte": "^5.36.0",
     "svelte-check": "^4.2.2",
     "svelte-i18n": "^4.0.1",
     "tiny-glob": "^0.2.9",
diff --git a/packages/e2e-tests/kit-node/src/lib/async-util.svelte.js b/packages/e2e-tests/kit-node/src/lib/async-util.svelte.js
@@ -0,0 +1,5 @@
+export async function asyncUtil() {
+	// async derived was added in svelte 5.36.0
+	const x = $derived(await 1);
+	return { x };
+}
diff --git a/packages/e2e-tests/kit-node/src/routes/+page.svelte b/packages/e2e-tests/kit-node/src/routes/+page.svelte
@@ -4,6 +4,7 @@
 	import Counter from '$lib/Counter.svelte';
 	import Child from '$lib/Child.svelte';
 	import { setSomeContext } from 'e2e-test-dep-svelte-api-only';
+	import { asyncUtil } from '$lib/async-util.svelte.js';
 	export let data = {};
 	$: load_status = data?.load_status ?? 'NOT_LOADED';
 	const jsTransform = '__JS_TRANSFORM_1__';
diff --git a/packages/e2e-tests/kit-node/svelte.config.js b/packages/e2e-tests/kit-node/svelte.config.js
@@ -3,6 +3,11 @@ import node from '@sveltejs/adapter-node';
 const config = {
 	kit: {
 		adapter: node()
+	},
+	compilerOptions: {
+		experimental: {
+			async: true
+		}
 	}
 };
 export default config;
diff --git a/packages/e2e-tests/package-json-svelte-field/package.json b/packages/e2e-tests/package-json-svelte-field/package.json
@@ -14,7 +14,7 @@
   "devDependencies": {
     "@sveltejs/vite-plugin-svelte": "workspace:^",
     "sass": "^1.89.2",
-    "svelte": "^5.35.2",
+    "svelte": "^5.36.0",
     "vite": "^7.0.2"
   },
   "type": "module"
diff --git a/packages/e2e-tests/prebundle-svelte-deps/package.json b/packages/e2e-tests/prebundle-svelte-deps/package.json
@@ -19,7 +19,7 @@
   "devDependencies": {
     "@sveltejs/vite-plugin-svelte": "workspace:^",
     "sass": "^1.89.2",
-    "svelte": "^5.35.2",
+    "svelte": "^5.36.0",
     "svelte-preprocess": "^6.0.3",
     "vite": "^7.0.2"
   }
diff --git a/packages/e2e-tests/preprocess-with-vite/package.json b/packages/e2e-tests/preprocess-with-vite/package.json
@@ -13,7 +13,7 @@
     "magic-string": "^0.30.17",
     "sass": "^1.89.2",
     "stylus": "^0.64.0",
-    "svelte": "^5.35.2",
+    "svelte": "^5.36.0",
     "vite": "^7.0.2"
   },
   "type": "module"
diff --git a/packages/e2e-tests/resolve-exports-svelte/package.json b/packages/e2e-tests/resolve-exports-svelte/package.json
@@ -13,7 +13,7 @@
   },
   "devDependencies": {
     "@sveltejs/vite-plugin-svelte": "workspace:^",
-    "svelte": "^5.35.2",
+    "svelte": "^5.36.0",
     "vite": "^7.0.2"
   }
 }
diff --git a/packages/e2e-tests/scan-deps/package.json b/packages/e2e-tests/scan-deps/package.json
@@ -10,7 +10,7 @@
   },
   "devDependencies": {
     "@sveltejs/vite-plugin-svelte": "workspace:^",
-    "svelte": "^5.35.2",
+    "svelte": "^5.36.0",
     "vite": "^7.0.2"
   }
 }
diff --git a/packages/e2e-tests/svelte-preprocess/package.json b/packages/e2e-tests/svelte-preprocess/package.json
@@ -10,7 +10,7 @@
   "devDependencies": {
     "@sveltejs/vite-plugin-svelte": "workspace:^",
     "sass": "^1.89.2",
-    "svelte": "^5.35.2",
+    "svelte": "^5.36.0",
     "svelte-preprocess": "^6.0.3",
     "typescript": "^5.8.3",
     "vite": "^7.0.2"
diff --git a/packages/e2e-tests/testUtils.ts b/packages/e2e-tests/testUtils.ts
@@ -18,6 +18,10 @@ import {
 	waitForViteConnect
 } from './vitestSetup.js';
 
+import { VERSION } from 'svelte/compiler';
+
+export const IS_SVELTE_BASELINE = VERSION === '5.0.0';
+
 export * from './vitestSetup.js';
 
 export const hmrUpdateTimeout = 10000;
diff --git a/packages/e2e-tests/ts-type-import/package.json b/packages/e2e-tests/ts-type-import/package.json
@@ -11,7 +11,7 @@
     "@sveltejs/vite-plugin-svelte": "workspace:^",
     "@tsconfig/svelte": "^5.0.4",
     "@types/node": "^22.16.0",
-    "svelte": "^5.35.2",
+    "svelte": "^5.36.0",
     "svelte-preprocess": "^6.0.3",
     "vite": "^7.0.2"
   },
diff --git a/packages/e2e-tests/vite-ssr-esm/package.json b/packages/e2e-tests/vite-ssr-esm/package.json
@@ -20,7 +20,7 @@
     "npm-run-all2": "^8.0.4",
     "polka": "1.0.0-next.28",
     "sirv": "^3.0.1",
-    "svelte": "^5.35.2",
+    "svelte": "^5.36.0",
     "vite": "^7.0.2"
   }
 }
diff --git a/packages/vite-plugin-svelte-inspector/package.json b/packages/vite-plugin-svelte-inspector/package.json
@@ -48,7 +48,7 @@
   },
   "devDependencies": {
     "@types/debug": "^4.1.12",
-    "svelte": "^5.35.2",
+    "svelte": "^5.36.0",
     "vite": "^7.0.2"
   }
 }
diff --git a/packages/vite-plugin-svelte/__tests__/svelte-version.spec.js b/packages/vite-plugin-svelte/__tests__/svelte-version.spec.js
@@ -0,0 +1,26 @@
+import { describe, it, expect } from 'vitest';
+import { gte } from '../src/utils/svelte-version.js';
+
+describe('gte', () => {
+	it('returns false for smaller patch', () => {
+		expect(gte('1.2.2', '1.2.3')).toBe(false);
+	});
+	it('returns false for smaller minor', () => {
+		expect(gte('1.1.4', '1.2.3')).toBe(false);
+	});
+	it('returns false for smaller major', () => {
+		expect(gte('0.3.4', '1.2.3')).toBe(false);
+	});
+	it('returns true for equal', () => {
+		expect(gte('1.2.3', '1.2.3')).toBe(true);
+	});
+	it('returns true for larger patch', () => {
+		expect(gte('1.2.4', '1.2.3')).toBe(true);
+	});
+	it('returns true for larger minor', () => {
+		expect(gte('1.3.1', '1.2.3')).toBe(true);
+	});
+	it('returns true for larger major', () => {
+		expect(gte('2.0.0', '1.2.3')).toBe(true);
+	});
+});
diff --git a/packages/vite-plugin-svelte/package.json b/packages/vite-plugin-svelte/package.json
@@ -53,7 +53,7 @@
   "devDependencies": {
     "@types/debug": "^4.1.12",
     "sass": "^1.89.2",
-    "svelte": "^5.35.2",
+    "svelte": "^5.36.0",
     "vite": "^7.0.2"
   }
 }
diff --git a/packages/vite-plugin-svelte/src/plugins/compile-module.js b/packages/vite-plugin-svelte/src/plugins/compile-module.js
diff --git a/packages/vite-plugin-svelte/src/utils/svelte-version.js b/packages/vite-plugin-svelte/src/utils/svelte-version.js
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml

Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,6 @@`
`15`	`15`	`},`
`16`	`16`	`"type": "module",`
`17`	`17`	`"dependencies": {`
`18`		`- "svelte": "^5.35.2"`
	`18`	`+ "svelte": "^5.36.0"`
`19`	`19`	`}`
`20`	`20`	`}`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@`
`11`	`11`	`"devDependencies": {`
`12`	`12`	`"@sveltejs/vite-plugin-svelte": "workspace:^",`
`13`	`13`	`"sass": "^1.89.2",`
`14`		`- "svelte": "^5.35.2",`
	`14`	`+ "svelte": "^5.36.0",`
`15`	`15`	`"vite": "^7.0.2"`
`16`	`16`	`}`
`17`	`17`	`}`