chore: add import for process instead of using global, remove some * as and fix other warnings

dominikg · dominikg · commit d9b7102ab6b1 · 2024-09-18T09:39:31.000+02:00
diff --git a/packages/e2e-tests/e2e-server.js b/packages/e2e-tests/e2e-server.js
@@ -3,6 +3,7 @@ import { execa } from 'execa';
 import treeKill from 'tree-kill';
 import fs from 'node:fs';
 import path from 'node:path';
+import process from 'node:process';
 const isWin = process.platform === 'win32';
 
 async function startedOnPort(serverProcess, port, timeout) {
diff --git a/packages/e2e-tests/testUtils.ts b/packages/e2e-tests/testUtils.ts
@@ -3,6 +3,7 @@
 // `import { getColor } from 'testUtils'`
 import fs from 'node:fs';
 import path from 'node:path';
+import process from 'node:process';
 import colors from 'css-color-names';
 import { ElementHandle } from 'playwright-core';
 import fetch from 'node-fetch';
diff --git a/packages/e2e-tests/vite-ssr-esm/server.js b/packages/e2e-tests/vite-ssr-esm/server.js
@@ -1,6 +1,7 @@
 // @ts-check
 import fs from 'node:fs';
 import path from 'node:path';
+import process from 'node:process';
 import { pathToFileURL } from 'node:url';
 import express from 'express';
 import compression from 'compression';
diff --git a/packages/e2e-tests/vitestGlobalSetup.ts b/packages/e2e-tests/vitestGlobalSetup.ts
@@ -1,6 +1,7 @@
 import os from 'node:os';
 import fs from 'fs-extra';
 import path from 'node:path';
+import process from 'node:process';
 import { chromium } from 'playwright-core';
 import { execa } from 'execa';
 import { fileURLToPath } from 'node:url';
diff --git a/packages/e2e-tests/vitestSetup.ts b/packages/e2e-tests/vitestSetup.ts
@@ -1,5 +1,6 @@
 import fs from 'fs-extra';
 import path from 'node:path';
+import process from 'node:process';
 import { chromium, type Browser, type Page } from 'playwright-core';
 import { beforeAll, type File } from 'vitest';
 import os from 'node:os';
diff --git a/packages/playground/basic/src/App.svelte b/packages/playground/basic/src/App.svelte
@@ -8,10 +8,10 @@
 
 <main>
 	<div>
-		<a href="https://vitejs.dev" target="_blank" rel="noreferrer">
+		<a href="https://vitejs.dev" target="_blank" rel="noreferrer" aria-label="vite homepage">
 			<img src={viteLogo} class="logo" alt="Vite Logo" />
 		</a>
-		<a href="https://svelte.dev" target="_blank" rel="noreferrer">
+		<a href="https://svelte.dev" target="_blank" rel="noreferrer" aria-label="svelte homepage">
 			<img src={svelteLogo} class="logo svelte" alt="Svelte Logo" />
 		</a>
 	</div>
diff --git a/packages/playground/big-component-library-kit/svelte.config.js b/packages/playground/big-component-library-kit/svelte.config.js
@@ -1,10 +1,13 @@
 import adapter from '@sveltejs/adapter-auto';
 import { optimizeImports } from 'carbon-preprocess-svelte';
-import preprocess from 'svelte-preprocess';
+import process from 'node:process';
+import { sveltePreprocess } from 'svelte-preprocess';
 
 /** @type {import('@sveltejs/kit').Config} */
 const config = {
-	preprocess: [preprocess(), process.env.DEEP_IMPORTS ? optimizeImports() : null].filter(Boolean),
+	preprocess: [sveltePreprocess(), process.env.DEEP_IMPORTS ? optimizeImports() : null].filter(
+		Boolean
+	),
 	kit: {
 		adapter: adapter()
 	}
diff --git a/packages/playground/big-component-library-vite-ssr/server.js b/packages/playground/big-component-library-vite-ssr/server.js
@@ -1,4 +1,5 @@
 import fs from 'node:fs/promises';
+import process from 'node:process';
 import express from 'express';
 
 // Constants
diff --git a/packages/playground/big-component-library-vite-ssr/svelte.config.js b/packages/playground/big-component-library-vite-ssr/svelte.config.js
@@ -1,5 +1,8 @@
 import { optimizeImports } from 'carbon-preprocess-svelte';
-import preprocess from 'svelte-preprocess';
+import process from 'node:process';
+import { sveltePreprocess } from 'svelte-preprocess';
 export default {
-	preprocess: [preprocess(), process.env.DEEP_IMPORTS ? optimizeImports() : null].filter(Boolean)
+	preprocess: [sveltePreprocess(), process.env.DEEP_IMPORTS ? optimizeImports() : null].filter(
+		Boolean
+	)
 };
diff --git a/packages/playground/big-component-library/svelte.config.js b/packages/playground/big-component-library/svelte.config.js
@@ -1,5 +1,8 @@
+import process from 'node:process';
 import { optimizeImports } from 'carbon-preprocess-svelte';
-import preprocess from 'svelte-preprocess';
+import { sveltePreprocess } from 'svelte-preprocess';
 export default {
-	preprocess: [preprocess(), process.env.DEEP_IMPORTS ? optimizeImports() : null].filter(Boolean)
+	preprocess: [sveltePreprocess(), process.env.DEEP_IMPORTS ? optimizeImports() : null].filter(
+		Boolean
+	)
 };
diff --git a/packages/playground/kit-demo-app/src/routes/Header.svelte b/packages/playground/kit-demo-app/src/routes/Header.svelte
@@ -8,7 +8,7 @@
 
 <header>
 	<div class="corner">
-		<a href="https://kit.svelte.dev">
+		<a href="https://kit.svelte.dev" aria-label="SvelteKit homepage">
 			<img src={logo} alt="SvelteKit" />
 		</a>
 	</div>
@@ -34,7 +34,7 @@
 	</nav>
 
 	<div class="corner">
-		<a href="https://github.com/sveltejs/kit">
+		<a href="https://github.com/sveltejs/kit" aria-label="SvelteKit github repository">
 			<img src={github} alt="GitHub" />
 		</a>
 	</div>
diff --git a/packages/vite-plugin-svelte-inspector/src/options.js b/packages/vite-plugin-svelte-inspector/src/options.js
@@ -1,3 +1,4 @@
+import process from 'node:process';
 import { loadEnv } from 'vite';
 import { debug } from './debug.js';
 
diff --git a/packages/vite-plugin-svelte/__tests__/compile.spec.js b/packages/vite-plugin-svelte/__tests__/compile.spec.js
@@ -1,3 +1,4 @@
+import process from 'node:process';
 import { describe, it, expect } from 'vitest';
 import { createCompileSvelte } from '../src/utils/compile.js';
 /** @type {import('../../types/options.d.ts').ResolvedOptions} */
diff --git a/packages/vite-plugin-svelte/src/index.js b/packages/vite-plugin-svelte/src/index.js
@@ -1,4 +1,5 @@
 import fs from 'node:fs';
+import process from 'node:process';
 import { svelteInspector } from '@sveltejs/vite-plugin-svelte-inspector';
 import { handleHotUpdate } from './handle-hot-update.js';
 import { log, logCompilerWarnings } from './utils/log.js';
diff --git a/packages/vite-plugin-svelte/src/preprocess.js b/packages/vite-plugin-svelte/src/preprocess.js
@@ -1,3 +1,4 @@
+import process from 'node:process';
 import { isCSSRequest, preprocessCSS, resolveConfig, transformWithEsbuild } from 'vite';
 import { mapToRelative, removeLangSuffix } from './utils/sourcemaps.js';
 
diff --git a/packages/vite-plugin-svelte/src/utils/hash.js b/packages/vite-plugin-svelte/src/utils/hash.js
@@ -1,4 +1,4 @@
-import * as crypto from 'node:crypto';
+import crypto from 'node:crypto';
 
 const hashes = Object.create(null);
 
diff --git a/packages/vite-plugin-svelte/src/utils/id.js b/packages/vite-plugin-svelte/src/utils/id.js
@@ -1,6 +1,7 @@
 import { createFilter, normalizePath } from 'vite';
-import * as fs from 'node:fs';
-import * as path from 'node:path';
+import fs from 'node:fs';
+import path from 'node:path';
+import process from 'node:process';
 import { log } from './log.js';
 import { DEFAULT_SVELTE_MODULE_EXT, DEFAULT_SVELTE_MODULE_INFIX } from './constants.js';
 
diff --git a/packages/vite-plugin-svelte/src/utils/load-svelte-config.js b/packages/vite-plugin-svelte/src/utils/load-svelte-config.js
@@ -1,5 +1,6 @@
 import { createRequire } from 'node:module';
 import path from 'node:path';
+import process from 'node:process';
 import fs from 'node:fs';
 import { pathToFileURL } from 'node:url';
 import { log } from './log.js';
diff --git a/packages/vite-plugin-svelte/src/utils/options.js b/packages/vite-plugin-svelte/src/utils/options.js
@@ -1,3 +1,4 @@
+import process from 'node:process';
 import { normalizePath } from 'vite';
 import { isDebugNamespaceEnabled, log } from './log.js';
 import { loadSvelteConfig } from './load-svelte-config.js';
diff --git a/packages/vite-plugin-svelte/src/utils/sourcemaps.js b/packages/vite-plugin-svelte/src/utils/sourcemaps.js
@@ -1,4 +1,5 @@
 import path from 'node:path';
+import process from 'node:process';
 
 const IS_WINDOWS = process.platform === 'win32';
 
diff --git a/packages/vite-plugin-svelte/types/index.d.ts.map b/packages/vite-plugin-svelte/types/index.d.ts.map
@@ -22,5 +22,5 @@
 		null,
 		null
 	],
-	"mappings": ";;;;aAIYA,OAAOA;;;;;;;;;;;;;kBAaFC,aAAaA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;kBAgGbC,YAAYA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;kBA8EZC,qBAAqBA;;;;;;;;;;;;;iBCvKtBC,MAAMA;iBCTNC,cAAcA;iBCgBRC,gBAAgBA"
+	"mappings": ";;;;aAIYA,OAAOA;;;;;;;;;;;;;kBAaFC,aAAaA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;kBAgGbC,YAAYA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;kBA8EZC,qBAAqBA;;;;;;;;;;;;;iBCtKtBC,MAAMA;iBCTNC,cAAcA;iBCgBRC,gBAAgBA"
 }
diff --git a/vitest.config.e2e.ts b/vitest.config.e2e.ts
@@ -1,5 +1,6 @@
 import * as path from 'node:path';
 import * as os from 'node:os';
+import * as process from 'node:process';
 
 import { defineConfig } from 'vitest/config';
 import { fileURLToPath } from 'node:url';
diff --git a/vitest.config.ts b/vitest.config.ts
@@ -1,4 +1,5 @@
 import { defineConfig } from 'vitest/config';
+import * as process from 'node:process';
 
 export default defineConfig({
 	test: {

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`import fs from 'node:fs/promises';`
	`2`	`+import process from 'node:process';`
`2`	`3`	`import express from 'express';`
`3`	`4`
`4`	`5`	`// Constants`