Skip to content

Commit dd7a9cf

Browse files
committed
chore: noExternal esm-env
1 parent e1aa2a1 commit dd7a9cf

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

packages/e2e-tests/kit-node/__tests__/kit.spec.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,8 @@ describe('kit-node', () => {
285285
'/^svelte\\//', // serialized with toString
286286
'e2e-test-dep-svelte-api-only',
287287
'svelte-i18n',
288-
'esm-env',
288+
'esm-env', // first added by svelte-kit
289+
'esm-env', // second added by vite-plugin-svelte
289290
'@sveltejs/kit'
290291
],
291292
`ssr.noExternal in ${filename}`

packages/vite-plugin-svelte/src/utils/options.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -572,6 +572,11 @@ function buildExtraConfigForSvelte(config) {
572572
if (!isDepExternaled('svelte', config.ssr?.external ?? [])) {
573573
noExternal.push('svelte', /^svelte\//);
574574
}
575+
// esm-env needs to be bundled by default for the development/production condition
576+
// be properly used by svelte
577+
if (!isDepExternaled('esm-env', config.ssr?.external ?? [])) {
578+
noExternal.push('esm-env');
579+
}
575580
return { optimizeDeps: { include, exclude }, ssr: { noExternal, external } };
576581
}
577582

0 commit comments

Comments
 (0)