Skip to content

Commit eb280eb

Browse files
committed
fix release workflow and update ci workflow to use the shared setup-node action
1 parent d145222 commit eb280eb

File tree

2 files changed

+9
-29
lines changed

2 files changed

+9
-29
lines changed

.github/workflows/ci.yml

Lines changed: 8 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -29,24 +29,15 @@ jobs:
2929
strategy:
3030
matrix:
3131
# pseudo-matrix for convenience, NEVER use more than a single combination
32-
node: [22]
32+
node: [24]
3333
os: [ubuntu-latest]
3434
steps:
35-
- uses: actions/checkout@v5
36-
- uses: actions/setup-node@v5
35+
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
3736
with:
38-
node-version: ${{ matrix.node }}
39-
package-manager-cache: false # pnpm is not installed yet
40-
- name: install pnpm
41-
shell: bash
42-
run: |
43-
PNPM_VER=$(jq -r '.packageManager | if .[0:5] == "pnpm@" then .[5:] else "packageManager in package.json does not start with pnpm@\n" | halt_error(1) end' package.json)
44-
echo installing pnpm version $PNPM_VER
45-
npm i -g pnpm@$PNPM_VER
46-
- uses: actions/setup-node@v5
37+
persist-credentials: 'false'
38+
- uses: ./.github/actions/setup-node
4739
with:
4840
node-version: ${{ matrix.node }}
49-
package-manager-cache: true # caches pnpm via packageManager field in package.json
5041
- name: install
5142
run: pnpm install --frozen-lockfile --prefer-offline --ignore-scripts
5243
- name: sync
@@ -100,24 +91,12 @@ jobs:
10091
vite: 'rolldown-vite'
10192
svelte: 'current'
10293
steps:
103-
- uses: actions/checkout@v5
104-
- uses: actions/checkout@v5
105-
- uses: actions/setup-node@v5
94+
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
10695
with:
107-
node-version: ${{ matrix.node }}
108-
package-manager-cache: false # pnpm is not installed yet
109-
- name: install pnpm
110-
shell: bash
111-
run: |
112-
PNPM_VER=$(jq -r '.packageManager | if .[0:5] == "pnpm@" then .[5:] else "packageManager in package.json does not start with pnpm@\n" | halt_error(1) end' package.json)
113-
echo installing pnpm version $PNPM_VER
114-
npm i -g pnpm@$PNPM_VER
115-
- uses: actions/setup-node@v5
96+
persist-credentials: 'false'
97+
- uses: ./.github/actions/setup-node
11698
with:
11799
node-version: ${{ matrix.node }}
118-
package-manager-cache: true # caches pnpm via packageManager field in package.json
119-
- name: install
120-
run: pnpm install --frozen-lockfile --ignore-scripts
121100
- name: downgrade vite to baseline
122101
if: matrix.vite == 'baseline'
123102
run: |
@@ -144,7 +123,7 @@ jobs:
144123
if: failure()
145124
shell: bash
146125
run: tar -cvf test-temp.tar --exclude="node_modules" temp/
147-
- uses: actions/upload-artifact@v4
126+
- uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
148127
if: failure()
149128
with:
150129
name: test-failure-${{github.run_id}}-os_${{ matrix.os }}-node_${{ matrix.node }}-vite_${{ matrix.vite }}-svelte_${{matrix.svelte}}

.github/workflows/release.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ jobs:
8282
github.com:443
8383
release-assets.githubusercontent.com:443
8484
registry.npmjs.org:443
85+
*.sigstore.dev:443
8586
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
8687
with:
8788
persist-credentials: 'false'

0 commit comments

Comments
 (0)