From 85fc2e7ee49c3773110020ffa67d05bf778aa612 Mon Sep 17 00:00:00 2001 From: dominikg Date: Fri, 4 Jul 2025 13:19:53 +0200 Subject: [PATCH 1/2] chore: skip extra typecheck when not rolldown-vite --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7bfdafbc2..3f27eed95 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -124,8 +124,8 @@ jobs: run: pnpm playwright install chromium - name: run tests run: pnpm test - - name: types - if: (${{ success() }} || ${{ failure() }}) + - name: check-types with rolldown-vite + if: (matrix.vite == 'rolldown-vite' && (${{ success() }} || ${{ failure() }})) run: pnpm check:types - name: archive tests temp directory if: failure() From 86c5aea166375c44ba9541b620ec162accd8d379 Mon Sep 17 00:00:00 2001 From: dominikg Date: Fri, 4 Jul 2025 13:34:06 +0200 Subject: [PATCH 2/2] try again --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 3f27eed95..914ea722b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -125,7 +125,7 @@ jobs: - name: run tests run: pnpm test - name: check-types with rolldown-vite - if: (matrix.vite == 'rolldown-vite' && (${{ success() }} || ${{ failure() }})) + if: matrix.vite == 'rolldown-vite' run: pnpm check:types - name: archive tests temp directory if: failure()