Skip to content

Commit 3fd0357

Browse files
authored
bridge: Reformat imports using nightly (#1280)
1 parent 460bec2 commit 3fd0357

File tree

26 files changed

+161
-98
lines changed

26 files changed

+161
-98
lines changed

.github/workflows/bridge-ci.yml

Lines changed: 17 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,20 @@ env:
2424
RUST_BACKTRACE: 1
2525

2626
jobs:
27+
check-fmt:
28+
name: Check formatting
29+
runs-on: ubuntu-latest
30+
steps:
31+
- uses: actions/checkout@v4
32+
33+
- uses: dtolnay/rust-toolchain@nightly
34+
with:
35+
components: rustfmt
36+
37+
- name: rustfmt
38+
run: cargo fmt -- --check
39+
working-directory: bridge
40+
2741
test-versions:
2842
name: Webhook Bridge CI
2943
runs-on: ubuntu-latest
@@ -32,10 +46,12 @@ jobs:
3246
rust: [stable, beta]
3347
steps:
3448
- uses: actions/checkout@v4
49+
3550
- uses: dtolnay/rust-toolchain@master
3651
with:
3752
toolchain: ${{ matrix.rust }}
38-
components: clippy, rustfmt
53+
components: clippy
54+
3955
- uses: Swatinem/rust-cache@v2
4056
with:
4157
workspaces: "bridge -> target"
@@ -47,10 +63,6 @@ jobs:
4763

4864
- uses: taiki-e/install-action@nextest
4965

50-
- name: rustfmt
51-
run: cargo fmt -- --check
52-
working-directory: bridge
53-
5466
- name: Install dependencies
5567
# Packages should align with whatever is in the bridge/Dockerfile
5668
run: |

bridge/.rustfmt.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
imports_granularity = "Crate"
2+
group_imports = "StdExternalCrate"

bridge/svix-bridge-plugin-queue/src/config.rs

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,17 @@
1-
pub use crate::gcp_pubsub::{GCPPubSubInputOpts, GCPPubSubOutputOpts};
2-
pub use crate::rabbitmq::{RabbitMqInputOpts, RabbitMqOutputOpts};
3-
pub use crate::receiver_output::QueueForwarder;
4-
pub use crate::redis::{RedisInputOpts, RedisOutputOpts};
5-
use crate::sender_input::QueueSender;
6-
pub use crate::sqs::{SqsInputOpts, SqsOutputOpts};
71
use serde::Deserialize;
82
use svix_bridge_types::{
93
ReceiverOutput, SenderInput, SenderOutputOpts, TransformationConfig, TransformerInputFormat,
104
};
115

6+
use crate::sender_input::QueueSender;
7+
pub use crate::{
8+
gcp_pubsub::{GCPPubSubInputOpts, GCPPubSubOutputOpts},
9+
rabbitmq::{RabbitMqInputOpts, RabbitMqOutputOpts},
10+
receiver_output::QueueForwarder,
11+
redis::{RedisInputOpts, RedisOutputOpts},
12+
sqs::{SqsInputOpts, SqsOutputOpts},
13+
};
14+
1215
#[derive(Deserialize)]
1316
pub struct QueueConsumerConfig {
1417
pub name: String,
@@ -85,14 +88,16 @@ pub enum ReceiverOutputOpts {
8588

8689
#[cfg(test)]
8790
mod tests {
88-
use super::into_receiver_output;
89-
use super::QueueConsumerConfig;
90-
use crate::config::{ReceiverOutputOpts, SenderInputOpts};
91-
use crate::redis::{RedisInputOpts, RedisOutputOpts};
9291
use svix_bridge_types::{
9392
SenderOutputOpts, SvixSenderOutputOpts, TransformationConfig, TransformerInputFormat,
9493
};
9594

95+
use super::{into_receiver_output, QueueConsumerConfig};
96+
use crate::{
97+
config::{ReceiverOutputOpts, SenderInputOpts},
98+
redis::{RedisInputOpts, RedisOutputOpts},
99+
};
100+
96101
// FIXME: can't support raw payload access for redis because it requires JSON internally.
97102
// Revisit after `omniqueue` adoption.
98103
#[test]

bridge/svix-bridge-plugin-queue/src/gcp_pubsub/mod.rs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
1-
use crate::error::{Error, Result};
1+
use std::path::PathBuf;
2+
23
use omniqueue::{backends, DynConsumer, DynProducer};
34
use serde::Deserialize;
4-
use std::path::PathBuf;
5+
6+
use crate::error::{Error, Result};
57

68
#[derive(Debug, Default, Deserialize)]
79
pub struct GCPPubSubInputOpts {

bridge/svix-bridge-plugin-queue/src/lib.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
use omniqueue::{Delivery, DynConsumer, QueueError};
21
use std::time::{Duration, Instant};
2+
3+
use omniqueue::{Delivery, DynConsumer, QueueError};
34
use svix_bridge_types::{
45
async_trait, svix::api::Svix, CreateMessageRequest, JsObject, TransformationConfig,
56
TransformerInput, TransformerInputFormat, TransformerJob, TransformerOutput, TransformerTx,

bridge/svix-bridge-plugin-queue/src/rabbitmq/mod.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
1-
use crate::error::{Error, Result};
21
use omniqueue::{backends, DynConsumer, DynProducer};
32
use serde::Deserialize;
43

4+
use crate::error::{Error, Result};
5+
56
#[derive(Debug, Deserialize)]
67
pub struct RabbitMqInputOpts {
78
/// Connection string for RabbitMQ.

bridge/svix-bridge-plugin-queue/src/receiver_output/mod.rs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
1-
use crate::config::ReceiverOutputOpts;
2-
use crate::error::Result;
3-
use omniqueue::DynProducer;
41
use std::sync::Arc;
2+
3+
use omniqueue::DynProducer;
54
use svix_bridge_types::{async_trait, ForwardRequest, ReceiverOutput};
65

6+
use crate::{config::ReceiverOutputOpts, error::Result};
7+
78
#[derive(Clone)]
89
pub struct QueueForwarder {
910
name: String,

bridge/svix-bridge-plugin-queue/src/redis/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
use crate::error::{Error, Result};
21
use omniqueue::{backends, DynConsumer, DynProducer};
3-
42
use serde::Deserialize;
53

4+
use crate::error::{Error, Result};
5+
66
#[derive(Debug, Default, Deserialize)]
77
pub struct RedisInputOpts {
88
pub dsn: String,

bridge/svix-bridge-plugin-queue/src/sender_input/mod.rs

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
1-
use crate::config::SenderInputOpts;
2-
use crate::{error::Error, gcp_pubsub, rabbitmq, run_inner, sqs, Consumer};
31
use omniqueue::DynConsumer;
4-
5-
use svix_bridge_types::svix::api::Svix;
62
use svix_bridge_types::{
7-
async_trait, SenderInput, SenderOutputOpts, TransformationConfig, TransformerTx,
3+
async_trait, svix::api::Svix, SenderInput, SenderOutputOpts, TransformationConfig,
4+
TransformerTx,
5+
};
6+
7+
use crate::{
8+
config::SenderInputOpts, error::Error, gcp_pubsub, rabbitmq, run_inner, sqs, Consumer,
89
};
910

1011
pub struct QueueSender {

bridge/svix-bridge-plugin-queue/src/sqs/mod.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
1-
use crate::error::{Error, Result};
21
use omniqueue::{backends, DynConsumer, DynProducer};
32
use serde::Deserialize;
43

4+
use crate::error::{Error, Result};
5+
56
#[derive(Debug, Default, Deserialize)]
67
pub struct SqsInputOpts {
78
pub queue_dsn: String,

0 commit comments

Comments
 (0)