Skip to content

Commit 6026dda

Browse files
jaymellsvix-james
authored andcommitted
Rename redisclusterunpooled to rediscluster
This is now our only clustered cache type, so simplify the name to match our prior clustered cache variant.
1 parent 57ef2e5 commit 6026dda

File tree

6 files changed

+10
-14
lines changed

6 files changed

+10
-14
lines changed

server/run-tests.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ echo "*********** RUN 3 ***********"
5050
echo "*********** RUN 4 ***********"
5151
(
5252
export SVIX_QUEUE_TYPE="rediscluster"
53-
export SVIX_CACHE_TYPE="redisclusterunpooled"
53+
export SVIX_CACHE_TYPE="rediscluster"
5454
export SVIX_REDIS_DSN="redis://localhost:6380"
5555
${TEST_COMMAND}
5656
${TEST_COMMAND} -- --ignored redis

server/svix-server/src/cfg.rs

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ pub struct ConfigurationInner {
193193
fn validate_config_complete(config: &ConfigurationInner) -> Result<(), ValidationError> {
194194
match config.cache_type {
195195
CacheType::None | CacheType::Memory => {}
196-
CacheType::Redis | CacheType::RedisClusterUnpooled => {
196+
CacheType::Redis | CacheType::RedisCluster => {
197197
if config.cache_dsn().is_none() {
198198
return Err(ValidationError {
199199
code: Cow::from("missing field"),
@@ -266,9 +266,7 @@ impl ConfigurationInner {
266266
CacheType::None => CacheBackend::None,
267267
CacheType::Memory => CacheBackend::Memory,
268268
CacheType::Redis => CacheBackend::Redis(self.cache_dsn().expect(err)),
269-
CacheType::RedisClusterUnpooled => {
270-
CacheBackend::RedisClusterUnpooled(self.cache_dsn().expect(err))
271-
}
269+
CacheType::RedisCluster => CacheBackend::RedisCluster(self.cache_dsn().expect(err)),
272270
}
273271
}
274272
}
@@ -305,7 +303,7 @@ pub enum CacheBackend<'a> {
305303
None,
306304
Memory,
307305
Redis(&'a str),
308-
RedisClusterUnpooled(&'a str),
306+
RedisCluster(&'a str),
309307
}
310308

311309
#[derive(Clone, Debug, Deserialize)]
@@ -337,7 +335,7 @@ pub enum QueueType {
337335
pub enum CacheType {
338336
Memory,
339337
Redis,
340-
RedisClusterUnpooled,
338+
RedisCluster,
341339
None,
342340
}
343341

server/svix-server/src/core/cache/redis.rs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -114,9 +114,7 @@ mod tests {
114114

115115
async fn get_pool(redis_dsn: &str, cfg: &crate::cfg::Configuration) -> RedisPool {
116116
match cfg.cache_type {
117-
CacheType::RedisClusterUnpooled => {
118-
crate::redis::new_redis_clustered_unpooled(redis_dsn).await
119-
}
117+
CacheType::RedisCluster => crate::redis::new_redis_clustered_unpooled(redis_dsn).await,
120118
CacheType::Redis => crate::redis::new_redis_pool(redis_dsn, cfg).await,
121119
_ => panic!(
122120
"This test should only be run when redis is configured as the cache provider"

server/svix-server/src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ pub async fn run_with_prefix(
113113
let mgr = crate::redis::new_redis_pool(dsn, &cfg).await;
114114
cache::redis::new(mgr)
115115
}
116-
CacheBackend::RedisClusterUnpooled(dsn) => {
116+
CacheBackend::RedisCluster(dsn) => {
117117
let mgr = crate::redis::new_redis_clustered_unpooled(dsn).await;
118118
cache::redis::new(mgr)
119119
}

server/svix-server/src/redis/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ mod tests {
245245

246246
async fn get_pool(redis_dsn: &str, cfg: &Configuration) -> RedisPool {
247247
match cfg.cache_type {
248-
CacheType::RedisClusterUnpooled => super::new_redis_clustered_unpooled(redis_dsn).await,
248+
CacheType::RedisCluster => super::new_redis_clustered_unpooled(redis_dsn).await,
249249
CacheType::Redis => super::new_redis_pool(redis_dsn, cfg).await,
250250
_ => panic!(
251251
"This test should only be run when redis is configured as the cache provider"

server/svix-server/tests/it/message_app.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ async fn test_app_deletion() {
6969
let mgr = new_redis_pool(dsn, &cfg).await;
7070
cache::redis::new(mgr)
7171
}
72-
CacheBackend::RedisClusterUnpooled(dsn) => {
72+
CacheBackend::RedisCluster(dsn) => {
7373
let mgr = new_redis_clustered_unpooled(dsn).await;
7474
cache::redis::new(mgr)
7575
}
@@ -153,7 +153,7 @@ async fn test_endp_deletion() {
153153
let mgr = new_redis_pool(dsn, &cfg).await;
154154
cache::redis::new(mgr)
155155
}
156-
CacheBackend::RedisClusterUnpooled(dsn) => {
156+
CacheBackend::RedisCluster(dsn) => {
157157
let mgr = new_redis_clustered_unpooled(dsn).await;
158158
cache::redis::new(mgr)
159159
}

0 commit comments

Comments
 (0)