Replace ctype_digit for php 8.1 deprecation of non-string arguments

jterry · jterry · commit fc49b72a1d0c · 2024-07-01T09:59:27.000-05:00
diff --git a/php/src/Webhook.php b/php/src/Webhook.php
@@ -70,7 +70,7 @@ public function verify($payload, $headers)
 
     public function sign($msgId, $timestamp, $payload)
     {
-        $is_positive_integer = ctype_digit($timestamp);
+        $is_positive_integer = is_numeric($timestamp) && (int) $timestamp == $timestamp && (int) $timestamp > 0;
         if (!$is_positive_integer) {
             throw new Exception\WebhookSigningException("Invalid timestamp");
         }

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ public function verify($payload, $headers)`
`70`	`70`
`71`	`71`	`public function sign($msgId, $timestamp, $payload)`
`72`	`72`	`{`
`73`		`- $is_positive_integer = ctype_digit($timestamp);`
	`73`	`+ $is_positive_integer = is_numeric($timestamp) && (int) $timestamp == $timestamp && (int) $timestamp > 0;`
`74`	`74`	`if (!$is_positive_integer) {`
`75`	`75`	`throw new Exception\WebhookSigningException("Invalid timestamp");`
`76`	`76`	`}`