Skip to content

Commit 7389a2a

Browse files
committed
add minimum length search query constraint
1 parent 322a3de commit 7389a2a

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

app/src/main/java/com/wardabbass/redit/MainActivity.kt

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import com.wardabbass.redit.ui.viewpager.NonSwipeCrossFadeViewPager
2121
import com.wardabbass.redit.ui.viewpager.ReditFragmentAdapter
2222
import com.wardabbass.redit.viewmodels.MainActivityViewModel
2323
import org.jetbrains.anko.dip
24+
import org.jetbrains.anko.longToast
2425
import org.jetbrains.anko.toast
2526

2627
class MainActivity : AppCompatActivity(), RedditPostClickDelegate, RedditPostBookMarkDelegate {
@@ -29,6 +30,7 @@ class MainActivity : AppCompatActivity(), RedditPostClickDelegate, RedditPostBoo
2930
companion object {
3031
const val EXTRA_QUERY = "query"
3132
const val EXTRA_SELECTED_SCREEN = "screen"
33+
const val MIN_QUERY_FOR_SEARCH = 3
3234
}
3335

3436
private lateinit var mainActivityViewModel: MainActivityViewModel
@@ -154,17 +156,20 @@ class MainActivity : AppCompatActivity(), RedditPostClickDelegate, RedditPostBoo
154156
*/
155157
private fun handleQuerySubmitted(query: String) {
156158
//toast("query $query")
157-
mainActivityViewModel.query.value = query
159+
if (query.length >= MIN_QUERY_FOR_SEARCH)
160+
mainActivityViewModel.query.value = query
161+
else
162+
longToast(getString(R.string.min_search_query))
158163
}
159164

160165
private fun handleSearchMenuCollapsed() {
161-
// toast("menu collapsed")
166+
// toast("menu collapsed")
162167
searchView?.setQuery("", false)
163168
mainActivityViewModel.query.value = ""
164169
}
165170

166171
private fun handleSearchMenuExpanded() {
167-
// toast("menu expanded")
172+
// toast("menu expanded")
168173

169174
// clearSearchMenuItem?.isVisible = false
170175

@@ -178,7 +183,7 @@ class MainActivity : AppCompatActivity(), RedditPostClickDelegate, RedditPostBoo
178183
}
179184

180185
override fun onReditPostBokkmarked(post: ReditPost, bookMarked: Boolean) {
181-
// toast("${post.title} is bookmarked? $bookMarked")
186+
// toast("${post.title} is bookmarked? $bookMarked")
182187
val bookMarksFrag = reditFragmentAdapter.getCachedItem(1) as BookmarkedFragment
183188
if (bookMarked) {
184189
bookMarksFrag.makeBookmark(post)

app/src/main/res/values/strings.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,5 @@
77

88
<!-- TODO: Remove or change this placeholder text -->
99
<string name="hello_blank_fragment">Hello blank fragment</string>
10+
<string name="min_search_query">Search query must be at least 3 letters</string>
1011
</resources>

0 commit comments

Comments
 (0)