Commit 172e6e4
fix(ls): address final PR #5104 review comments
Remove redundant toValue() calls in allowedFields linter function where
parentKey is already extracted. Rename test fixture to follow standard
naming convention without -invalid suffix.
Changes:
- Optimize linter-functions.ts line 244 to use parentKey directly
- Rename operation-reply-fields-types-3-0-invalid.yaml to match pattern
- Update test reference in operation-reply.ts
Fixes remaining issues from PR #5104 comments 37, 39, 43, 45, 46.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>1 parent 615ae6b commit 172e6e4
File tree
4 files changed
+9
-36
lines changed- packages/apidom-ls
- src/services/validation
- test
- fixtures/validation/asyncapi
4 files changed
+9
-36
lines changedLines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
241 | 241 | | |
242 | 242 | | |
243 | 243 | | |
244 | | - | |
245 | | - | |
| 244 | + | |
| 245 | + | |
246 | 246 | | |
247 | 247 | | |
248 | 248 | | |
| |||
packages/apidom-ls/test/fixtures/validation/asyncapi/operation-reply-fields-types-3-0-invalid.yaml
Lines changed: 0 additions & 19 deletions
This file was deleted.
Lines changed: 6 additions & 14 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
| 26 | + | |
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| |||
0 commit comments