fix: parameter unique name validation for oas2

Author: robert-hebel-sb

packages/apidom-ls/src/config/openapi/parameter/lint/unique-name.ts

@@ -10,7 +10,7 @@ const parametersTypeLint: LinterMeta = {
   message: 'Name must be unique among all parameters',
   severity: DiagnosticSeverity.Error,
   linterFunction: 'apilintPropertyUniqueSiblingValue',
-  linterParams: [['parameters'], 'name'],
+  linterParams: ['parameters', 'name'],
   marker: 'key',
   markerTarget: 'name',
   target: 'name',

packages/apidom-ls/test/fixtures/validation/oas/parameter-unique-name-2-0.yaml

@@ -0,0 +1,21 @@
+swagger: "2.0"
+info:
+  version: 1.0.0
+  title: 'test'
+paths:
+  /pets:
+    get:
+      responses:
+      parameters:
+        - name: pathLevel
+          type: string
+          in: query
+          description: tags to filter by
+          schema:
+            type: string
+        - name: pathLevel
+          type: string
+          in: query
+          description: tags to filter by
+          schema:
+            type: string

packages/apidom-ls/test/validate.ts

@@ -3714,6 +3714,69 @@ describe('apidom-ls-validate', function () {
     languageService.terminate();
   });
 
+  it('oas 2.0 / yaml - parameter name should be unique', async function () {
+    const validationContext: ValidationContext = {
+      comments: DiagnosticSeverity.Error,
+      maxNumberOfProblems: 100,
+      relatedInformation: false,
+    };
+
+    const spec = fs
+      .readFileSync(
+        path.join(__dirname, 'fixtures', 'validation', 'oas', 'parameter-unique-name-2-0.yaml'),
+      )
+      .toString();
+    const doc: TextDocument = TextDocument.create(
+      'foo://bar/parameter-unique-name-2-0.yaml',
+      'yaml',
+      0,
+      spec,
+    );
+
+    const languageService: LanguageService = getLanguageService(contextNoSchema);
+
+    const result = await languageService.doValidation(doc, validationContext);
+    const expected: Diagnostic[] = [
+      {
+        code: 3103000,
+        data: {},
+        message: 'Name must be unique among all parameters',
+        range: {
+          end: {
+            character: 14,
+            line: 9,
+          },
+          start: {
+            character: 10,
+            line: 9,
+          },
+        },
+        severity: 1,
+        source: 'apilint',
+      },
+      {
+        code: 3103000,
+        data: {},
+        message: 'Name must be unique among all parameters',
+        range: {
+          end: {
+            character: 14,
+            line: 15,
+          },
+          start: {
+            character: 10,
+            line: 15,
+          },
+        },
+        severity: 1,
+        source: 'apilint',
+      },
+    ];
+    assert.deepEqual(result, expected as Diagnostic[]);
+
+    languageService.terminate();
+  });
+
   it('oas 3.0 / yaml - parameter Authorization is ignored', async function () {
     const validationContext: ValidationContext = {
       comments: DiagnosticSeverity.Error,