feat: migrate unique parameter name

Author: robert-hebel-sb

packages/apidom-ls/src/config/codes.ts

@@ -740,6 +740,7 @@ enum ApilintCodes {
   OPENAPI2_PARAMETER_FIELD_ENUM_TYPE = 3101800,
   OPENAPI2_PARAMETER_FIELD_MULTIPLE_OF_TYPE = 3101900,
   OPENAPI2_PARAMETER_FIELD_IN_PATH_TEMPLATE = 3102000,
+  OPENAPI2_PARAMETER_FIELD_NAME_UNIQUE = 3103000,
 
   OPENAPI2_ITEMS = 3110000,
   OPENAPI2_ITEMS_FIELD_TYPE_EQUALS = 3110100,

packages/apidom-ls/src/config/openapi/parameter/lint/index.ts

@@ -42,6 +42,7 @@ import uniqueItemsTypeLint from './unique-items--type.ts';
 import enumTypeLint from './enum--type.ts';
 import multipleOfTypeLint from './multiple-of--type.ts';
 import inPathTemplateLint from './in-path-template.ts';
+import uniqueNameLint from './unique-name.ts';
 
 const lints = [
   nameTypeLint,
@@ -81,6 +82,7 @@ const lints = [
   maxLengthTypeLint,
   minLengthTypeLint,
   uniqueItemsTypeLint,
+  uniqueNameLint,
   enumTypeLint,
   multipleOfTypeLint,
   requiredFields3_0__3_1Lint,

packages/apidom-ls/src/config/openapi/parameter/lint/unique-name.ts

@@ -0,0 +1,21 @@
+import { DiagnosticSeverity } from 'vscode-languageserver-types';
+
+import ApilintCodes from '../../../codes.ts';
+import { LinterMeta } from '../../../../apidom-language-types.ts';
+import { OpenAPI2, OpenAPI3 } from '../../target-specs.ts';
+
+const parametersTypeLint: LinterMeta = {
+  code: ApilintCodes.OPENAPI2_PARAMETER_FIELD_NAME_UNIQUE,
+  source: 'apilint',
+  message: 'Name must be unique among all parameters',
+  severity: DiagnosticSeverity.Error,
+  linterFunction: 'apilintPropertyUniqueValue',
+  linterParams: [['parameters'], 'name'],
+  marker: 'key',
+  markerTarget: 'name',
+  target: 'name',
+  data: {},
+  targetSpecs: [...OpenAPI2, ...OpenAPI3],
+};
+
+export default parametersTypeLint;

packages/apidom-ls/test/fixtures/validation/oas/parameter-unique-name-3-0.yaml

@@ -0,0 +1,19 @@
+openapi: 3.0.0
+info:
+  version: 1.0.0
+  title: 'test'
+paths:
+  /pets:
+    get:
+      responses:
+      parameters:
+        - name: pathLevel
+          in: query
+          description: tags to filter by
+          schema:
+            type: string
+        - name: pathLevel
+          in: query
+          description: tags to filter by
+          schema:
+            type: string

packages/apidom-ls/test/validate.ts

@@ -3651,6 +3651,69 @@ describe('apidom-ls-validate', function () {
     languageService.terminate();
   });
 
+  it('oas 3.0 / yaml - parameter name should be unique', async function () {
+    const validationContext: ValidationContext = {
+      comments: DiagnosticSeverity.Error,
+      maxNumberOfProblems: 100,
+      relatedInformation: false,
+    };
+
+    const spec = fs
+      .readFileSync(
+        path.join(__dirname, 'fixtures', 'validation', 'oas', 'parameter-unique-name-3-0.yaml'),
+      )
+      .toString();
+    const doc: TextDocument = TextDocument.create(
+      'foo://bar/parameter-unique-name-3-0.yaml',
+      'yaml',
+      0,
+      spec,
+    );
+
+    const languageService: LanguageService = getLanguageService(contextNoSchema);
+
+    const result = await languageService.doValidation(doc, validationContext);
+    const expected: Diagnostic[] = [
+      {
+        code: 3103000,
+        data: {},
+        message: 'Name must be unique among all parameters',
+        range: {
+          end: {
+            character: 14,
+            line: 9,
+          },
+          start: {
+            character: 10,
+            line: 9,
+          },
+        },
+        severity: 1,
+        source: 'apilint',
+      },
+      {
+        code: 3103000,
+        data: {},
+        message: 'Name must be unique among all parameters',
+        range: {
+          end: {
+            character: 14,
+            line: 14,
+          },
+          start: {
+            character: 10,
+            line: 14,
+          },
+        },
+        severity: 1,
+        source: 'apilint',
+      },
+    ];
+    assert.deepEqual(result, expected as Diagnostic[]);
+
+    languageService.terminate();
+  });
+
   it('oas 3.1 / yaml - parameter object should be defined within path template', async function () {
     const validationContext: ValidationContext = {
       comments: DiagnosticSeverity.Error,