Skip to content

Commit 773aade

Browse files
authored
Merge pull request #584 from michaeldavis-wf/fix-property-sanitization
[AbstractJavaCodegen] Fix property sanitization
2 parents 2a561d8 + 723745f commit 773aade

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

src/main/java/io/swagger/codegen/v3/generators/java/AbstractJavaCodegen.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1146,10 +1146,10 @@ public String sanitizeVarName(String name) {
11461146
// remove everything else other than word, number and _
11471147
// $php_variable => php_variable
11481148
if (allowUnicodeIdentifiers) { //could be converted to a single line with ?: operator
1149-
name = Pattern.compile("\\W-[\\$]", Pattern.UNICODE_CHARACTER_CLASS).matcher(name).replaceAll(StringUtils.EMPTY);
1149+
name = Pattern.compile("[\\W&&[^$]]", Pattern.UNICODE_CHARACTER_CLASS).matcher(name).replaceAll(StringUtils.EMPTY);
11501150
}
11511151
else {
1152-
name = name.replaceAll("\\W-[\\$]", StringUtils.EMPTY);
1152+
name = name.replaceAll("[\\W&&[^$]]", StringUtils.EMPTY);
11531153
}
11541154
return name;
11551155
}

src/test/java/io/swagger/codegen/v3/generators/java/AbstractJavaCodegenTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@ public void convertVarName() throws Exception {
9595
Assert.assertEquals(fakeJavaCodegen.toVarName("user-name"), "userName");
9696
Assert.assertEquals(fakeJavaCodegen.toVarName("user_name"), "userName");
9797
Assert.assertEquals(fakeJavaCodegen.toVarName("_user_name"), "_userName");
98+
Assert.assertEquals(fakeJavaCodegen.toVarName(":user_name"), "userName");
9899
}
99100

100101
@Test

0 commit comments

Comments
 (0)