Skip to content

Commit a2bc5c2

Browse files
Merge branch 'master' into issue-444
2 parents debd429 + 1130576 commit a2bc5c2

File tree

3 files changed

+10
-8
lines changed

3 files changed

+10
-8
lines changed

src/main/java/io/swagger/codegen/v3/generators/DefaultCodegenConfig.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1276,8 +1276,6 @@ public CodegenModel fromModel(String name, Schema schema, Map<String, Schema> al
12761276
}
12771277
codegenModel.getVendorExtensions().put(CodegenConstants.IS_ALIAS_EXT_NAME, typeAliases.containsKey(name));
12781278

1279-
codegenModel.discriminator = schema.getDiscriminator();
1280-
12811279
if (schema.getXml() != null) {
12821280
codegenModel.xmlPrefix = schema.getXml().getPrefix();
12831281
codegenModel.xmlNamespace = schema.getXml().getNamespace();
@@ -1342,6 +1340,14 @@ else if (schema instanceof ComposedSchema) {
13421340
final List<Schema> allOf = composed.getAllOf();
13431341
// interfaces (intermediate models)
13441342
if (allOf != null && !allOf.isEmpty()) {
1343+
1344+
if (schema.getDiscriminator() != null) {
1345+
codegenModel.discriminator = schema.getDiscriminator();
1346+
if (codegenModel.discriminator != null && codegenModel.discriminator.getPropertyName() != null) {
1347+
codegenModel.discriminator.setPropertyName(toVarName(codegenModel.discriminator.getPropertyName()));
1348+
}
1349+
}
1350+
13451351
for (int i = 0; i < allOf.size(); i++) {
13461352
if (i == 0 && !copyFistAllOfProperties) {
13471353
continue;

src/test/java/io/swagger/codegen/v3/generators/swift/Swift3ModelTest.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ public void simpleModelTest() {
3131
Assert.assertEquals(cm.classname, "Sample");
3232
Assert.assertEquals(cm.description, "a sample model");
3333
Assert.assertEquals(cm.vars.size(), 7);
34-
Assert.assertEquals(cm.discriminator.getPropertyName(),"test");
3534

3635
final CodegenProperty property1 = cm.vars.get(0);
3736
Assert.assertEquals(property1.baseName, "id");
@@ -119,8 +118,7 @@ private Schema getSimpleSchema() {
119118
.addProperties("uuid", new UUIDSchema())
120119
.addProperties("dateOfBirth", new DateSchema())
121120
.addRequiredItem("id")
122-
.addRequiredItem("name")
123-
.discriminator(new Discriminator().propertyName("test"));
121+
.addRequiredItem("name");
124122
}
125123

126124
}

src/test/java/io/swagger/codegen/v3/generators/swift/Swift4ModelTest.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ public void simpleModelTest() {
3131
Assert.assertEquals(cm.classname, "Sample");
3232
Assert.assertEquals(cm.description, "a sample model");
3333
Assert.assertEquals(cm.vars.size(), 7);
34-
Assert.assertEquals(cm.discriminator.getPropertyName(),"test");
3534

3635
final CodegenProperty property1 = cm.vars.get(0);
3736
Assert.assertEquals(property1.baseName, "id");
@@ -119,8 +118,7 @@ private Schema getSimpleSchema() {
119118
.addProperties("uuid", new UUIDSchema())
120119
.addProperties("dateOfBirth", new DateSchema())
121120
.addRequiredItem("id")
122-
.addRequiredItem("name")
123-
.discriminator(new Discriminator().propertyName("test"));
121+
.addRequiredItem("name");
124122
}
125123

126124
}

0 commit comments

Comments
 (0)