Skip to content

Commit f10a1a0

Browse files
committed
refs #1319 - fix validation
1 parent 4d4fd87 commit f10a1a0

File tree

3 files changed

+20
-9
lines changed

3 files changed

+20
-9
lines changed

src/main/java/io/swagger/codegen/v3/generators/java/SpringCodegen.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -293,6 +293,7 @@ public void processOpts() {
293293

294294
if (additionalProperties.containsKey(USE_BEANVALIDATION)) {
295295
this.setUseBeanValidation(convertPropertyToBoolean(USE_BEANVALIDATION));
296+
writePropertyBack(USE_BEANVALIDATION, this.useBeanValidation);
296297
}
297298

298299
if (additionalProperties.containsKey(USE_OPTIONAL)) {
@@ -320,10 +321,10 @@ public void processOpts() {
320321
if (useBeanValidation) {
321322
writePropertyBack(USE_BEANVALIDATION, useBeanValidation);
322323
if (VALIDATION_MODE_LOOSE.equals(validationMode) || VALIDATION_MODE_STRICT.equals(validationMode)) {
323-
supportingFiles.add(new SupportingFile("NotUndefined.mustache",
324-
(sourceFolder + File.separator + configPackage).replace(".", java.io.File.separator), "NotUndefined.java"));
325-
supportingFiles.add(new SupportingFile("NotUndefinedValidator.mustache",
326-
(sourceFolder + File.separator + configPackage).replace(".", java.io.File.separator), "NotUndefinedValidator.java"));
324+
writeOptional(outputFolder, new SupportingFile("NotUndefined.mustache",
325+
(sourceFolder + File.separator + configPackage).replace(".", java.io.File.separator), "NotUndefined.java"), true);
326+
writeOptional(outputFolder, new SupportingFile("NotUndefinedValidator.mustache",
327+
(sourceFolder + File.separator + configPackage).replace(".", java.io.File.separator), "NotUndefinedValidator.java"), true);
327328
}
328329
}
329330

src/main/resources/handlebars/JavaSpring/model.mustache

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,11 @@ import java.io.Serializable;
1111
import org.springframework.validation.annotation.Validated;
1212
{{#isLooseValidation}}
1313
import org.openapitools.jackson.nullable.JsonNullable;
14-
import io.swagger.configuration.NotUndefined;
14+
import {{configPackage}}.NotUndefined;
1515
{{/isLooseValidation}}
1616
{{#isStrictValidation}}
1717
import org.openapitools.jackson.nullable.JsonNullable;
18-
import io.swagger.configuration.NotUndefined;
18+
import {{configPackage}}.NotUndefined;
1919
import com.fasterxml.jackson.annotation.JsonInclude;
2020
import com.fasterxml.jackson.annotation.JsonSetter;
2121
import com.fasterxml.jackson.annotation.Nulls;

src/test/java/io/swagger/codegen/v3/generators/java/SpringGeneratorTest.java

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,9 @@ public class SpringGeneratorTest extends AbstractCodegenTest {
2020
@Test
2121
public void testGenerator() throws Exception {
2222

23+
System.setProperty("supportingFiles", "false");
24+
System.setProperty("generateModels", "true");
25+
System.setProperty("generateApis", "true");
2326
String path = getOutFolder(false).getAbsolutePath();
2427
GenerationRequest request = new GenerationRequest();
2528
request
@@ -32,13 +35,20 @@ public void testGenerator() throws Exception {
3235
false)) // OpenAPI 3.x - use true for Swagger/OpenAPI 2.x definitions
3336
.options(
3437
new Options()
35-
// .library("spring-boot3")
36-
// .addAdditionalProperty("jakarta", true)
38+
.addAdditionalProperty("dateLibrary", "legacy")
39+
.addAdditionalProperty("serializableModel", false)
40+
.addAdditionalProperty("useTags", true)
41+
.addAdditionalProperty("generateForOpenFeign", true)
42+
.addAdditionalProperty("configPackage", "test.configPackage")
43+
// .addAdditionalProperty("generateSupportingFiles", false)
44+
.library("spring-cloud")
45+
.addAdditionalProperty("jakarta", true)
3746
// .addAdditionalProperty("validationMode", "loose")
3847
// .addAdditionalProperty("validationMode", "legacy")
3948
// .addAdditionalProperty("validationMode", "legacyNullable")
40-
// .addAdditionalProperty("useBeanValidation", false)
49+
.addAdditionalProperty("useBeanValidation", false)
4150
// .addAdditionalProperty("useNullableForNotNull", false)
51+
.modelPackage("test.foo")
4252
.outputDir(path)
4353
);
4454

0 commit comments

Comments
 (0)