Skip to content

Commit 1f36096

Browse files
hrachyahrachya
authored andcommitted
Simplifying CliOption class
1 parent 08647b3 commit 1f36096

File tree

4 files changed

+22
-38
lines changed

4 files changed

+22
-38
lines changed

modules/swagger-codegen/src/main/java/com/wordnik/swagger/codegen/CliOption.java

Lines changed: 12 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -5,40 +5,24 @@
55
*/
66
package com.wordnik.swagger.codegen;
77

8-
import org.apache.commons.cli.Option;
8+
public class CliOption {
9+
private final String opt;
10+
private String description;
911

10-
public class CliOption extends Option {
11-
12-
private Boolean langSpecific = false;
13-
14-
public CliOption(String opt, String description) throws IllegalArgumentException {
15-
super(opt, description);
16-
}
17-
18-
public CliOption(String opt, boolean hasArg, String description) throws IllegalArgumentException {
19-
super(opt, hasArg, description);
20-
}
21-
22-
public CliOption(String opt, String longOpt, boolean hasArg, String description) throws IllegalArgumentException {
23-
super(opt, longOpt, hasArg, description);
24-
}
25-
26-
public CliOption(String opt, String description, Boolean langSpecific) throws IllegalArgumentException {
27-
this(opt, description);
28-
this.langSpecific = langSpecific;
12+
public CliOption(String opt, String description) {
13+
this.opt = opt;
14+
this.description = description;
2915
}
3016

31-
public CliOption(String opt, boolean hasArg, String description, Boolean langSpecific) throws IllegalArgumentException {
32-
this(opt, hasArg, description);
33-
this.langSpecific = langSpecific;
17+
public String getOpt() {
18+
return opt;
3419
}
3520

36-
public CliOption(String opt, String longOpt, boolean hasArg, String description, Boolean langSpecific) throws IllegalArgumentException {
37-
this(opt, longOpt, hasArg, description);
38-
this.langSpecific = langSpecific;
21+
public String getDescription() {
22+
return description;
3923
}
4024

41-
public Boolean isLangSpecific() {
42-
return langSpecific;
25+
public void setDescription(String description) {
26+
this.description = description;
4327
}
4428
}

modules/swagger-codegen/src/main/java/com/wordnik/swagger/codegen/DefaultCodegen.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -303,8 +303,8 @@ public DefaultCodegen() {
303303
importMapping.put("LocalDate", "org.joda.time.*");
304304
importMapping.put("LocalTime", "org.joda.time.*");
305305

306-
cliOptions.add(new CliOption("modelPackage", "model-package", true, "Package for generated models"));
307-
cliOptions.add(new CliOption("apiPackage", "api-package", true, "Package for generated api classes"));
306+
cliOptions.add(new CliOption("modelPackage", "package for generated models"));
307+
cliOptions.add(new CliOption("apiPackage", "package for generated api classes"));
308308
}
309309

310310

modules/swagger-codegen/src/main/java/com/wordnik/swagger/codegen/languages/JavaClientCodegen.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,11 @@ public JavaClientCodegen() {
5959
instantiationTypes.put("array", "ArrayList");
6060
instantiationTypes.put("map", "HashMap");
6161

62-
cliOptions.add(new CliOption("invokerPackage", "invoker-package", true, "Root package for generated code", true));
63-
cliOptions.add(new CliOption("groupId", "group-id", true, "groupId in pom.xml", true));
64-
cliOptions.add(new CliOption("artifactId", "artifact-id", true, "groupId in pom.xml", true));
65-
cliOptions.add(new CliOption("artifactVersion", "artifact-version", true, "artifact version in pom.xml", true));
66-
cliOptions.add(new CliOption("sourceFolder", "source-folder", true, "Source folder for generated code", true));
62+
cliOptions.add(new CliOption("invokerPackage", "root package for generated code"));
63+
cliOptions.add(new CliOption("groupId", "groupId in generated pom.xml"));
64+
cliOptions.add(new CliOption("artifactId", "artifactId in generated pom.xml"));
65+
cliOptions.add(new CliOption("artifactVersion", "artifact version in generated pom.xml"));
66+
cliOptions.add(new CliOption("sourceFolder", "source folder for generated code"));
6767
}
6868

6969
@Override

modules/swagger-codegen/src/main/java/com/wordnik/swagger/codegen/languages/ObjcClientCodegen.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -106,9 +106,9 @@ public ObjcClientCodegen() {
106106
instantiationTypes.put("array", "NSMutableArray");
107107
instantiationTypes.put("map", "NSMutableDictionary");
108108

109-
cliOptions.add(new CliOption("classPrefix", "class-prefix", true, "prefix for generated classes", true));
110-
cliOptions.add(new CliOption("sourceFolder", "source-folder", true, "source folder for generated code", true));
111-
cliOptions.add(new CliOption("projectName", "project-name", true, "name of the Xcode project in generated Podfile", true));
109+
cliOptions.add(new CliOption("classPrefix", "prefix for generated classes"));
110+
cliOptions.add(new CliOption("sourceFolder", "source folder for generated code"));
111+
cliOptions.add(new CliOption("projectName", "name of the Xcode project in generated Podfile"));
112112
}
113113

114114
@Override

0 commit comments

Comments
 (0)