Skip to content

Commit 52d5742

Browse files
authored
Merge pull request #11271 from swagger-api/phpReadmeOption
allow full url in php option
2 parents 8ccfc82 + e8775cf commit 52d5742

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

modules/swagger-codegen/src/main/java/io/swagger/codegen/v3/config/CodegenConfigurator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ public class CodegenConfigurator implements Serializable {
8787

8888
private String gitUserId="GIT_USER_ID";
8989
private String gitRepoId="GIT_REPO_ID";
90-
private String gitRepoBaseURL = "github";
90+
private String gitRepoBaseURL = "https://github.com";
9191
private String releaseNote="Minor update";
9292
private String httpUserAgent;
9393

modules/swagger-codegen/src/test/java/io/swagger/codegen/v3/service/GeneratorServiceTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ public void testGeneratorService_readmeV3() throws IOException {
9090
.outputDir(path)
9191
.gitRepoId("TestRepo")
9292
.gitUserId("testuser")
93-
.gitRepoBaseURL("gitlab")
93+
.gitRepoBaseURL("https://gitlab.com")
9494
);
9595
List<File> files = new GeneratorService().generationRequest(request).generate();
9696
Assert.assertFalse(files.isEmpty());
@@ -127,7 +127,7 @@ public void testGeneratorService_readmeV3_NoOption() throws IOException {
127127
for (File f: files) {
128128
String relPath = f.getAbsolutePath().substring(path.length());
129129
if ("/SwaggerClient-php/README.md".equals(relPath)) {
130-
Assert.assertTrue(FileUtils.readFileToString(f).contains("http://github.com/testuser"));
130+
Assert.assertTrue(FileUtils.readFileToString(f).contains("https://github.com/testuser"));
131131
}
132132
}
133133
}

0 commit comments

Comments
 (0)