Skip to content

Commit 7bde2ff

Browse files
committed
Fix Java Generator to always generate valid Java variable names
1 parent f17654c commit 7bde2ff

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

src/main/resources/Java/api.mustache

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,10 @@ public class {{classname}} {
4141
{{/requiredParamCount}}
4242

4343
{{#queryParams}}if(!"null".equals(String.valueOf({{paramName}})))
44-
queryParams.put("{{paramName}}", String.valueOf({{paramName}}));
44+
queryParams.put("{{baseName}}", String.valueOf({{paramName}}));
4545
{{/queryParams}}
4646

47-
{{#headerParams}}headerParams.put("{{paramName}}", {{paramName}});
47+
{{#headerParams}}headerParams.put("{{baseName}}", {{paramName}});
4848
{{/headerParams}}
4949

5050
String contentType = "application/json";
@@ -68,4 +68,4 @@ public class {{classname}} {
6868
}
6969
{{/operation}}
7070
}
71-
{{/operations}}
71+
{{/operations}}

src/main/scala/com/wordnik/swagger/codegen/BasicJavaGenerator.scala

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,11 @@ class BasicJavaGenerator extends BasicGenerator {
9393
// file suffix
9494
override def fileSuffix = ".java"
9595

96+
override def toVarName(name: String): String = {
97+
val paramName = name.replaceAll("[^a-zA-Z0-9_]","")
98+
super.toVarName(paramName)
99+
}
100+
96101
// response classes
97102
override def processResponseClass(responseClass: String): Option[String] = {
98103
responseClass match {
@@ -209,4 +214,4 @@ class BasicJavaGenerator extends BasicGenerator {
209214
("JsonUtil.mustache", destinationDir + java.io.File.separator + invokerPackage.get.replace(".", java.io.File.separator) + java.io.File.separator, "JsonUtil.java"),
210215
("apiException.mustache", destinationDir + java.io.File.separator + invokerPackage.get.replace(".", java.io.File.separator) + java.io.File.separator, "ApiException.java"),
211216
("pom.mustache", "generated-code/java", "pom.xml"))
212-
}
217+
}

0 commit comments

Comments
 (0)