Skip to content

Commit 82ee6bb

Browse files
authored
Merge pull request #3278 from wing328/escape_unsafe_2
Better handling of multi-line comments for all generators
2 parents dd53f84 + 8a3c2e7 commit 82ee6bb

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+313
-68
lines changed

modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/AbstractCSharpCodegen.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -665,7 +665,7 @@ public String escapeQuotationMark(String input) {
665665

666666
@Override
667667
public String escapeUnsafeCharacters(String input) {
668-
return input.replace("*/", "");
668+
return input.replace("*/", "*_/").replace("/*", "/_*");
669669
}
670670

671671
}

modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/AbstractJavaCodegen.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -842,7 +842,7 @@ public String escapeQuotationMark(String input) {
842842

843843
@Override
844844
public String escapeUnsafeCharacters(String input) {
845-
return input.replace("*/", "");
845+
return input.replace("*/", "*_/").replace("/*", "/_*");
846846
}
847847

848848
}

modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/AbstractTypeScriptClientCodegen.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -311,4 +311,15 @@ public void setSupportsES6(Boolean value) {
311311
public Boolean getSupportsES6() {
312312
return supportsES6;
313313
}
314+
315+
@Override
316+
public String escapeQuotationMark(String input) {
317+
// remove ', " to avoid code injection
318+
return input.replace("\"", "").replace("'", "");
319+
}
320+
321+
@Override
322+
public String escapeUnsafeCharacters(String input) {
323+
return input.replace("*/", "*_/").replace("/*", "/_*");
324+
}
314325
}

modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/AkkaScalaClientCodegen.java

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -414,4 +414,14 @@ public String formatFragment(String fragment) {
414414
}
415415
}
416416

417+
@Override
418+
public String escapeQuotationMark(String input) {
419+
// remove " to avoid code injection
420+
return input.replace("\"", "");
421+
}
422+
423+
@Override
424+
public String escapeUnsafeCharacters(String input) {
425+
return input.replace("*/", "*_/").replace("/*", "/_*");
426+
}
417427
}

modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/AndroidClientCodegen.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -504,4 +504,15 @@ public void setSourceFolder(String sourceFolder) {
504504
this.sourceFolder = sourceFolder;
505505
}
506506

507+
@Override
508+
public String escapeQuotationMark(String input) {
509+
// remove " to avoid code injection
510+
return input.replace("\"", "");
511+
}
512+
513+
@Override
514+
public String escapeUnsafeCharacters(String input) {
515+
return input.replace("*/", "*_/").replace("/*", "/_*");
516+
}
517+
507518
}

modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/ClojureClientCodegen.java

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -212,4 +212,16 @@ public Map<String, Object> postProcessOperations(Map<String, Object> operations)
212212
protected String namespaceToFolder(String ns) {
213213
return ns.replace(".", File.separator).replace("-", "_");
214214
}
215+
216+
@Override
217+
public String escapeQuotationMark(String input) {
218+
// remove " to avoid code injection
219+
return input.replace("\"", "");
220+
}
221+
222+
@Override
223+
public String escapeUnsafeCharacters(String input) {
224+
// ref: https://clojurebridge.github.io/community-docs/docs/clojure/comment/
225+
return input.replace("(comment", "(_comment");
226+
}
215227
}

modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/CppRestClientCodegen.java

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -377,4 +377,16 @@ public String toVarName(String name) {
377377
public String toApiName(String type) {
378378
return Character.toUpperCase(type.charAt(0)) + type.substring(1) + "Api";
379379
}
380+
381+
@Override
382+
public String escapeQuotationMark(String input) {
383+
// remove " to avoid code injection
384+
return input.replace("\"", "");
385+
}
386+
387+
@Override
388+
public String escapeUnsafeCharacters(String input) {
389+
return input.replace("*/", "*_/").replace("/*", "/_*");
390+
}
391+
380392
}

modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/CsharpDotNet2ClientCodegen.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -274,4 +274,15 @@ public String toOperationId(String operationId) {
274274
return camelize(operationId);
275275
}
276276

277+
@Override
278+
public String escapeQuotationMark(String input) {
279+
// remove " to avoid code injection
280+
return input.replace("\"", "");
281+
}
282+
283+
@Override
284+
public String escapeUnsafeCharacters(String input) {
285+
return input.replace("*/", "*_/").replace("/*", "/_*");
286+
}
287+
277288
}

modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/DartClientCodegen.java

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -289,4 +289,16 @@ public void setPubDescription(String pubDescription) {
289289
public void setSourceFolder(String sourceFolder) {
290290
this.sourceFolder = sourceFolder;
291291
}
292+
293+
@Override
294+
public String escapeQuotationMark(String input) {
295+
// remove " to avoid code injection
296+
return input.replace("\"", "");
297+
}
298+
299+
@Override
300+
public String escapeUnsafeCharacters(String input) {
301+
return input.replace("*/", "*_/").replace("/*", "/_*");
302+
}
303+
292304
}

modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/FlashClientCodegen.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -373,4 +373,15 @@ public void setInvokerPackage(String invokerPackage) {
373373
public void setSourceFolder(String sourceFolder) {
374374
this.sourceFolder = sourceFolder;
375375
}
376+
377+
@Override
378+
public String escapeQuotationMark(String input) {
379+
// remove " to avoid code injection
380+
return input.replace("\"", "");
381+
}
382+
383+
@Override
384+
public String escapeUnsafeCharacters(String input) {
385+
return input.replace("*/", "*_/").replace("/*", "/_*");
386+
}
376387
}

0 commit comments

Comments
 (0)