Skip to content

Commit 91d2852

Browse files
authored
Merge pull request #9383 from zhwei/fix-php-symfony
[BUG] [CRITICAL] [PHP] Symfony server incorrect api input validation: min contstraint in max condition
2 parents 79e800a + 88b784a commit 91d2852

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

modules/swagger-codegen/src/main/resources/php-symfony/api_input_validation.mustache

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,10 @@
6161
{{/minimum}}
6262
{{#maximum}}
6363
{{#exclusiveMaximum}}
64-
$asserts[] = new Assert\LessThan({{minimum}});
64+
$asserts[] = new Assert\LessThan({{maximum}});
6565
{{/exclusiveMaximum}}
6666
{{^exclusiveMaximum}}
67-
$asserts[] = new Assert\LessThanOrEqual({{minimum}});
67+
$asserts[] = new Assert\LessThanOrEqual({{maximum}});
6868
{{/exclusiveMaximum}}
6969
{{/maximum}}
7070
{{#pattern}}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
2.4.3-SNAPSHOT
1+
2.4.5-SNAPSHOT

samples/server/petstore/php-symfony/SymfonyBundle-php/Controller/StoreController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ public function getOrderByIdAction(Request $request, $orderId)
227227
$asserts[] = new Assert\NotNull();
228228
$asserts[] = new Assert\Type("int");
229229
$asserts[] = new Assert\GreaterThanOrEqual(1);
230-
$asserts[] = new Assert\LessThanOrEqual(1);
230+
$asserts[] = new Assert\LessThanOrEqual(5);
231231
$response = $this->validate($orderId, $asserts);
232232
if ($response instanceof Response) {
233233
return $response;

0 commit comments

Comments
 (0)