Skip to content

Commit d5f17a1

Browse files
committed
Merge pull request #1818 from swagger-api/issue-1817
updated parentModel names in inheritence situations
2 parents e83cea0 + ba9bd11 commit d5f17a1

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

modules/swagger-codegen/src/main/java/io/swagger/codegen/DefaultCodegen.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -788,9 +788,9 @@ public CodegenModel fromModel(String name, Model model, Map<String, Model> allDe
788788
// parent model
789789
final RefModel parent = (RefModel) composed.getParent();
790790
if (parent != null) {
791-
final String parentRef = toModelName(parent.getSimpleRef());
791+
final String parentRef = parent.getSimpleRef();
792792
m.parent = parentRef;
793-
addImport(m, parentRef);
793+
addImport(m, toModelName(parent.getSimpleRef()));
794794
if (!supportsInheritance && allDefinitions != null) {
795795
final Model parentModel = allDefinitions.get(parentRef);
796796
if (parentModel instanceof ModelImpl) {

modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/JavaClientCodegen.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -456,7 +456,7 @@ public CodegenModel fromModel(String name, Model model, Map<String, Model> allDe
456456
CodegenModel codegenModel = super.fromModel(name, model, allDefinitions);
457457

458458
if (allDefinitions != null && codegenModel != null && codegenModel.parent != null && codegenModel.hasEnums) {
459-
final Model parentModel = allDefinitions.get(toModelName(codegenModel.parent));
459+
final Model parentModel = allDefinitions.get(codegenModel.parent);
460460
final CodegenModel parentCodegenModel = super.fromModel(codegenModel.parent, parentModel);
461461
codegenModel = this.reconcileInlineEnums(codegenModel, parentCodegenModel);
462462
}

modules/swagger-codegen/src/test/java/io/swagger/codegen/java/JavaModelEnumTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,14 +73,14 @@ public void overrideEnumTest() {
7373

7474
final DefaultCodegen codegen = new JavaClientCodegen();
7575
final Map<String, Model> allModels = new HashMap<String, Model>();
76-
allModels.put(codegen.toModelName(parentModel.getName()), parentModel);
77-
allModels.put(codegen.toModelName(subModel.getName()), subModel);
76+
allModels.put(parentModel.getName(), parentModel);
77+
allModels.put(subModel.getName(), subModel);
7878

7979
final CodegenModel cm = codegen.fromModel("sample", model, allModels);
8080

8181
Assert.assertEquals(cm.name, "sample");
8282
Assert.assertEquals(cm.classname, "Sample");
83-
Assert.assertEquals(cm.parent, "ParentModel");
83+
Assert.assertEquals(cm.parent, "parentModel");
8484
Assert.assertTrue(cm.imports.contains("ParentModel"));
8585

8686
// Assert that only the unshared/uninherited enum remains

0 commit comments

Comments
 (0)