modifying PHP templates and rules to meet PSR2 standards

some rules around whitespace have been disabled, since we don't have a
great deal of control over whitespace that is emitted when template
values are empty.

Author: mattmelling

modules/swagger-codegen/src/main/resources/php/.php_cs

@@ -8,9 +8,16 @@ return PhpCsFixer\Config::create()
         'phpdoc_order' => true,
         'array_syntax' => [ 'syntax' => 'short' ],
         'strict_comparison' => true,
-        'strict_param' => true
+        'strict_param' => true,
+        'no_trailing_whitespace' => false,
+        'no_trailing_whitespace_in_comment' => false,
+        'braces' => false,
+        'single_blank_line_at_eof' => false,
+        'blank_line_after_namespace' => false,
     ])
     ->setFinder(
         PhpCsFixer\Finder::create()
+        ->exclude('test')
+        ->exclude('tests')
         ->in(__DIR__)
     );

modules/swagger-codegen/src/main/resources/php/HeaderSelector.mustache

@@ -97,4 +97,3 @@ class HeaderSelector
         }
     }
 }
-

modules/swagger-codegen/src/main/resources/php/ObjectSerializer.mustache

@@ -58,7 +58,7 @@ class ObjectSerializer
                 if ($value !== null
                     && !in_array($swaggerType, [{{&primitives}}], true)
                     && method_exists($swaggerType, 'getAllowableEnumValues')
-                    && !in_array($value, $swaggerType::getAllowableEnumValues())) {
+                    && !in_array($value, $swaggerType::getAllowableEnumValues(), true)) {
                     $imploded = implode("', '", $swaggerType::getAllowableEnumValues());
                     throw new \InvalidArgumentException("Invalid value for enum '$swaggerType', must be one of: '$imploded'");
                 }
@@ -274,7 +274,7 @@ class ObjectSerializer
 
             return new \SplFileObject($filename, 'r');
         } elseif (method_exists($class, 'getAllowableEnumValues')) {
-            if (!in_array($data, $class::getAllowableEnumValues())) {
+            if (!in_array($data, $class::getAllowableEnumValues(), true)) {
                 $imploded = implode("', '", $class::getAllowableEnumValues());
                 throw new \InvalidArgumentException("Invalid value for enum '$class', must be one of: '$imploded'");
             }

modules/swagger-codegen/src/main/resources/php/model_generic.mustache

@@ -166,7 +166,7 @@ class {{classname}} {{#parentSchema}}extends {{{parent}}} {{/parentSchema}}{{^pa
         {{#discriminator}}
 
         // Initialize discriminator property with the model name.
-        $discriminator = array_search('{{discriminator}}', self::$attributeMap);
+        $discriminator = array_search('{{discriminator}}', self::$attributeMap, true);
         $this->container[$discriminator] = static::$swaggerModelName;
         {{/discriminator}}
     }