[Bug]: [swagger-core-jakarta] ModelConverterContextImpl does not properly cache AnnotatedType

[anteperic]

Description of the problem/issue

Based on analysis, swagger-core-jakarta does not properly cache (store) already processed AnnotatedTypes.

For instance, Java String type is always recalculated as it is not found in:
private final Set<AnnotatedType> processedTypes;

Root cause is probably faulty equals() or hashcode() implementation in the `AnnotatedType.

Affected Version

Discovered in 2.2.27

Steps to Reproduce

A simple code modification of the io.swagger.v3.core.converter.ModelConverterContextImpl can showcase that the same types are "recalculated" See "CONVERTERS" part.

    @Override
    public Schema resolve(AnnotatedType type) {

        AnnotatedType aType = ReferenceTypeUtils.unwrapReference(type);
        if (aType != null) {
            return resolve(aType);
        }

        if (processedTypes.contains(type)) {
            return modelByType.get(type);
        } else {
            processedTypes.add(type);
        }
        Iterator<ModelConverter> converters = this.getConverters();
        Schema resolved = null;
        if (converters.hasNext()) {
            var start = System.currentTimeMillis();
            ModelConverter converter = converters.next();
            LOGGER.info("[CONVERTERS] {}", type.getType().getTypeName());
            resolved = converter.resolve(type, this, converters);
            var duration = System.currentTimeMillis() - start;
            LOGGER.info("[CONVERTERS] {} took {}ms", type.getType().getTypeName(), duration);
        }

        if (resolved != null) {
            modelByType.put(type, resolved);

            Schema resolvedImpl = resolved;
            if (resolvedImpl.getName() != null) {
                modelByName.put(resolvedImpl.getName(), resolved);
            }
        } else {
            processedTypes.remove(type);
        }

        return resolved;
    }

Expected Behavior & Actual Behavior

Swagger Schema for repeating AnnotatedTypes should not be resolved by converter. Instead, value should be fetched from existing modelByType.

Logs / Stack Traces

This is an example from our machine. Note: some specifics are omitted.

2025-09-02T17:43:21.124 INFO qtp1695504428-376 io.swagger.v3.core.converter.ModelConverterContextImpl - [CONVERTERS] [simple type, class java.lang.String]
2025-09-02T17:43:21.124 INFO qtp1695504428-376 io.swagger.v3.core.converter.ModelConverterContextImpl - [CONVERTERS] [simple type, class java.lang.String] took 0ms
2025-09-02T17:43:21.124 INFO qtp1695504428-376 io.swagger.v3.core.converter.ModelConverterContextImpl - [CONVERTERS] [simple type, class java.lang.String]
2025-09-02T17:43:21.124 INFO qtp1695504428-376 io.swagger.v3.core.converter.ModelConverterContextImpl - [CONVERTERS] [simple type, class java.lang.String] took 0ms
2025-09-02T17:43:21.124 INFO qtp1695504428-376 io.swagger.v3.core.converter.ModelConverterContextImpl - [CONVERTERS] [simple type, class java.util.Date]
2025-09-02T17:43:21.124 INFO qtp1695504428-376 io.swagger.v3.core.converter.ModelConverterContextImpl - [CONVERTERS] [simple type, class java.util.Date] took 0ms
2025-09-02T17:43:21.125 INFO qtp1695504428-376 io.swagger.v3.core.converter.ModelConverterContextImpl - [CONVERTERS] [simple type, class java.lang.Long]
2025-09-02T17:43:21.125 INFO qtp1695504428-376 io.swagger.v3.core.converter.ModelConverterContextImpl - [CONVERTERS] [simple type, class java.lang.Long] took 0ms
2025-09-02T17:43:21.125 INFO qtp1695504428-376 io.swagger.v3.core.converter.ModelConverterContextImpl - [CONVERTERS] [simple type, class int]
2025-09-02T17:43:21.125 INFO qtp1695504428-376 io.swagger.v3.core.converter.ModelConverterContextImpl - [CONVERTERS] [simple type, class int] took 0ms
2025-09-02T17:43:21.125 INFO qtp1695504428-376 io.swagger.v3.core.converter.ModelConverterContextImpl - [CONVERTERS] java.lang.String
2025-09-02T17:43:21.125 INFO qtp1695504428-376 io.swagger.v3.core.converter.ModelConverterContextImpl - [CONVERTERS] java.lang.String took 0ms
2025-09-02T17:43:21.127 INFO qtp1695504428-376 io.swagger.v3.core.converter.ModelConverterContextImpl - [CONVERTERS] [simple type, class java.lang.String]
2025-09-02T17:43:21.127 INFO qtp1695504428-376 io.swagger.v3.core.converter.ModelConverterContextImpl - [CONVERTERS] [simple type, class java.lang.String] took 0ms
2025-09-02T17:43:21.127 INFO qtp1695504428-376 io.swagger.v3.core.converter.ModelConverterContextImpl - [CONVERTERS] [simple type, class java.lang.String]
2025-09-02T17:43:21.127 INFO qtp1695504428-376 io.swagger.v3.core.converter.ModelConverterContextImpl - [CONVERTERS] [simple type, class java.lang.String] took 0ms
2025-09-02T17:43:21.129 INFO qtp1695504428-376 io.swagger.v3.core.converter.ModelConverterContextImpl - [CONVERTERS] [simple type, class java.lang.String]
2025-09-02T17:43:21.129 INFO qtp1695504428-376 io.swagger.v3.core.converter.ModelConverterContextImpl - [CONVERTERS] [simple type, class java.lang.String] took 0ms
2025-09-02T17:43:21.130 INFO qtp1695504428-376 io.swagger.v3.core.converter.ModelConverterContextImpl - [CONVERTERS] java.lang.String
2025-09-02T17:43:21.130 INFO qtp1695504428-376 io.swagger.v3.core.converter.ModelConverterContextImpl - [CONVERTERS] java.lang.String took 0ms
2025-09-02T17:43:21.133 INFO qtp1695504428-376 io.swagger.v3.core.converter.ModelConverterContextImpl - [CONVERTERS] [simple type, class java.lang.String]
2025-09-02T17:43:21.133 INFO qtp1695504428-376 io.swagger.v3.core.converter.ModelConverterContextImpl - [CONVERTERS] [simple type, class java.lang.String] took 0ms
2025-09-02T17:43:21.133 INFO qtp1695504428-376 io.swagger.v3.core.converter.ModelConverterContextImpl - [CONVERTERS] [simple type, class java.lang.String]
2025-09-02T17:43:21.133 INFO qtp1695504428-376 io.swagger.v3.core.converter.ModelConverterContextImpl - [CONVERTERS] [simple type, class java.lang.String] took 0ms
2025-09-02T17:43:21.133 INFO qtp1695504428-376 io.swagger.v3.core.converter.ModelConverterContextImpl - [CONVERTERS] [simple type, class java.lang.String]
2025-09-02T17:43:21.133 INFO qtp1695504428-376 io.swagger.v3.core.converter.ModelConverterContextImpl - [CONVERTERS] [simple type, class java.lang.String] took 0ms
2025-09-02T17:43:21.134 INFO qtp1695504428-376 io.swagger.v3.core.converter.ModelConverterContextImpl - [CONVERTERS] [simple type, class java.lang.String]
2025-09-02T17:43:21.134 INFO qtp1695504428-376 io.swagger.v3.core.converter.ModelConverterContextImpl - [CONVERTERS] [simple type, class java.lang.String] took 1ms
2025-09-02T17:43:21.134 INFO qtp1695504428-376 io.swagger.v3.core.converter.ModelConverterContextImpl - [CONVERTERS] [simple type, class java.lang.String]
2025-09-02T17:43:21.134 INFO qtp1695504428-376 io.swagger.v3.core.converter.ModelConverterContextImpl - [CONVERTERS] [simple type, class java.lang.String] took 0ms
2025-09-02T17:43:21.134 INFO qtp1695504428-376 io.swagger.v3.core.converter.ModelConverterContextImpl - [CONVERTERS] [simple type, class java.util.Date]
2025-09-02T17:43:21.134 INFO qtp1695504428-376 io.swagger.v3.core.converter.ModelConverterContextImpl - [CONVERTERS] [simple type, class java.util.Date] took 0ms

Additional Context

Checklist

• I have searched the existing issues and this is not a duplicate.
• I have provided sufficient information for maintainers to reproduce the issue.

[juntae6942]

anteperic Hi, could you please assign this issue to me? I’d like to work on it and submit a PR.

[anteperic]

anteperic Hi, could you please assign this issue to me? I’d like to work on it and submit a PR.

Hello, I believe seagger team can only assign you to the ticket. I’m not able to do it.

[juntae6942]

anteperic Ah, thank you for letting me know. My apologies if my intention wasn't clear.

I was just wondering if you were planning to work on this yourself. If not, I'd be happy to give it a try and submit a pull request.

[ewaostrowska]

@juntae6942 , @anteperic
I assigned @juntae6942 to the issue. We are looking forward to the PR from you!

[juntae6942]

ewaostrowska Thank you for assigning this to me. I am currently contributing to another Swagger-related issue, so I will complete that first and then proceed with this task.

[juntae6942]

ewaostrowska Fix PR: #4975 PTAL 😃

[ewaostrowska]

Hi @juntae6942,
Thanks for your PR. It does fix the described issue, but I have pointed in the comment of the PR what other cases could be addressed as well in the area of AnnotatedType equals/hashCode. Please let us know if you'd like to take the topic further :)

[juntae6942]

ewaostrowska Thanks for the detailed feedback! Yes, I'm happy to take this further. I'll look into the points you raised and update the PR.