fix(build): add proper inline bundling for SVG assets (#21)

char0n · web-flow · commit c30ae47a2fea · 2023-08-20T17:33:30.000+02:00
Refs swagger-api/swagger-editor#3741
diff --git a/packages/react-scripts/config/webpack.config.bundle.esm.js b/packages/react-scripts/config/webpack.config.bundle.esm.js
@@ -107,7 +107,7 @@ module.exports = function (webpackEnv) {
      * We want all SVG files become part of the bundle.
      */
     svgRule.type = 'asset/inline';
-    svgRule.use.pop();
+    delete svgRule.use;
   } else {
     svgRule.use[1].options.name = '[name].[hash].[ext]';
   }
diff --git a/packages/react-scripts/config/webpack.config.bundle.umd.js b/packages/react-scripts/config/webpack.config.bundle.umd.js
@@ -65,7 +65,7 @@ const commonConfig = webpackEnv => {
      * We want all SVG files become part of the bundle.
      */
     svgRule.type = 'asset/inline';
-    svgRule.use.pop();
+    delete svgRule.use;
   } else {
     svgRule.use[1].options.name = '[name].[hash].[ext]';
   }

Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,7 @@ module.exports = function (webpackEnv) {`
`107`	`107`	`* We want all SVG files become part of the bundle.`
`108`	`108`	`*/`
`109`	`109`	`svgRule.type = 'asset/inline';`
`110`		`- svgRule.use.pop();`
	`110`	`+ delete svgRule.use;`
`111`	`111`	`} else {`
`112`	`112`	`svgRule.use[1].options.name = '[name].[hash].[ext]';`
`113`	`113`	`}`
Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ const commonConfig = webpackEnv => {`
`65`	`65`	`* We want all SVG files become part of the bundle.`
`66`	`66`	`*/`
`67`	`67`	`svgRule.type = 'asset/inline';`
`68`		`- svgRule.use.pop();`
	`68`	`+ delete svgRule.use;`
`69`	`69`	`} else {`
`70`	`70`	`svgRule.use[1].options.name = '[name].[hash].[ext]';`
`71`	`71`	`}`