fix(semval): sbuject OAS3 req/res schemas to schema validation (#1769)

Author: shockey

src/plugins/validate-semantic/selectors.js

@@ -74,6 +74,22 @@ export const isParameterSchema = (state, node) => (sys) => {
   }
 }
 
+export const isOAS3RequestBodySchema = (state, node) => () => {
+  const [key,, gpKey, ggpKey] = node.path.slice().reverse()
+
+  return key === "schema"
+    && gpKey === "content"
+    && ggpKey === "requestBody"
+}
+
+export const isOAS3ResponseSchema = (state, node) => () => {
+  const [key,, gpKey,, gggpKey] = node.path.slice().reverse()
+
+  return key === "schema"
+    && gpKey === "content"
+    && gggpKey === "responses"
+}
+
 export const isResponse = (state, node) => (sys) => {
   if(sys.validateSelectors.isVendorExt(node)) {
     return false
@@ -116,6 +132,7 @@ export const allSchemas = () => (system) => {
     validateSelectors.allDefinitions(),
     validateSelectors.allHeaders(),
     validateSelectors.allSubSchemas(),
+    validateSelectors.allOAS3OperationSchemas()
   ]
 
   return Promise.all(selectors)
@@ -211,6 +228,20 @@ export const allParameterSchemas = () => (system) => {
   })
 }
 
+export const allOAS3OperationSchemas = () => (system) => {
+  return system.fn.traverseOnce({
+    name: "allOAS3OperationSchemas",
+    fn: (node) => {
+      if(
+        system.validateSelectors.isOAS3RequestBodySchema(node)
+         || system.validateSelectors.isOAS3ResponseSchema(node)
+       ) {
+        return node
+      }
+    },
+  })
+}
+
 export const allHeaders = () => (system) => {
   return system.fn.traverseOnce({
     name: "allHeader",

test/plugins/selectors.js

@@ -245,4 +245,47 @@ describe("validation plugin - selectors", function() {
         expect(nodes[2].key).toEqual("foo")
       })
   })
+  it("allSchemas should pick up OAS3 request and response schemas", () => {
+    const spec = {
+      "openapi": "3.0.0",
+      "paths": {
+        "/ping": {
+          "post": {
+            "requestBody": {
+              "content": {
+                "application/myRequestMediaType": {
+                  "schema": {
+                    "type": "array"
+                  }
+                }
+              }
+            },
+            "responses": {
+              "200": {
+                "description": "OK",
+                "content": {
+                  "application/myResponseMediaType": {
+                    "schema": {
+                      "type": "string"
+                    }
+                  }
+                }
+              }
+            }
+          }
+        }
+      }
+    }
+
+    return getSystem(spec)
+      .then(system => system.validateSelectors.allSchemas())
+      .then(nodes => {
+        expect(nodes.length).toEqual(2)
+        expect(nodes[0].node).toNotBe(nodes[1].node)
+        expect(nodes[0].key).toEqual("schema")
+        expect(nodes[0].parent.key).toEqual("application/myRequestMediaType")
+        expect(nodes[1].key).toEqual("schema")
+        expect(nodes[1].parent.key).toEqual("application/myResponseMediaType")
+      })
+  })
 })