fix: suppress string method on undefined error in case of malformed $ref (via #1955)

shockey · web-flow · commit 0544f4109d11 · 2019-02-28T20:33:58.000-08:00
diff --git a/src/plugins/validate-semantic/validators/oas3/refs.js b/src/plugins/validate-semantic/validators/oas3/refs.js
@@ -10,7 +10,7 @@ export const validateOAS3RefsForRequestBodiesReferenceRequestBodyPositions = ()
           return acc
         }
 
-        const [, refPath] = ref.split("#")
+        const [, refPath = ""] = ref.split("#")
         const pathArr = refPath.split("/") || []
         const parentRefKey = pathArr.slice(-2)[0]
         const targetRefKey = pathArr.slice(-1)[0]

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ export const validateOAS3RefsForRequestBodiesReferenceRequestBodyPositions = ()`
`10`	`10`	`return acc`
`11`	`11`	`}`
`12`	`12`
`13`		`- const [, refPath] = ref.split("#")`
	`13`	`+ const [, refPath = ""] = ref.split("#")`
`14`	`14`	`const pathArr = refPath.split("/") \|\| []`
`15`	`15`	`const parentRefKey = pathArr.slice(-2)[0]`
`16`	`16`	`const targetRefKey = pathArr.slice(-1)[0]`