Merge pull request #1544 from shockey/bug/1414-autosuggest-repeated-characters

Add try/catch to Ace autocompleters

Author: shockey

src/plugins/editor-autosuggest/helpers.js

@@ -12,28 +12,34 @@ export function wrapCompleters(completers, cutoff = 100) {
     let ori = completer.getCompletions
     completer.getCompletions = function(editor, session, pos, prefix, callback) {
       let startTime = Date.now()
-      ori(editor, session, pos, prefix, (...args) => {
-        let msElapsed = Date.now() - startTime
-        lastSpeeds[i] = msElapsed
+      try {
+        ori(editor, session, pos, prefix, (...args) => {
+          let msElapsed = Date.now() - startTime
+          lastSpeeds[i] = msElapsed
 
-        if(isLiveCompletionDisabled && isPerformant()) {
-          console.warn("Manual autocomplete was performant - re-enabling live autocomplete")
-          editor.setOptions({
-            enableLiveAutocompletion: true
-          })
-          isLiveCompletionDisabled = false
-        }
+          if(isLiveCompletionDisabled && isPerformant()) {
+            console.warn("Manual autocomplete was performant - re-enabling live autocomplete")
+            editor.setOptions({
+              enableLiveAutocompletion: true
+            })
+            isLiveCompletionDisabled = false
+          }
 
-        if(msElapsed > cutoff && editor.getOption("enableLiveAutocompletion")) {
-          console.warn("Live autocomplete is slow - disabling it")
-          editor.setOptions({
-            enableLiveAutocompletion: false
-          })
-          isLiveCompletionDisabled = true
-        }
+          if(msElapsed > cutoff && editor.getOption("enableLiveAutocompletion")) {
+            console.warn("Live autocomplete is slow - disabling it")
+            editor.setOptions({
+              enableLiveAutocompletion: false
+            })
+            isLiveCompletionDisabled = true
+          }
 
-        callback(...args)
-      })
+          callback(...args)
+        })
+      } catch(e) {
+        console.error("Autocompleter encountered an error")
+        console.error(e)
+        callback(null, [])
+      }
     }
     return completer
   })