Make validators more robust; less error-prone

Author: shockey

src/plugins/validation/semantic-validators/validators/operations.js

@@ -17,6 +17,10 @@ export function validate({ resolvedSpec }) {
       let pathOps = pick(path, ["get", "head", "post", "put", "patch", "delete", "options"])
       each(pathOps, (op, opKey) => {
 
+        if(!op) {
+          return
+        }
+
         // Assertation 1
         let bodyParamIndex = findIndex(op.parameters, ["in", "body"])
         let formDataParamIndex = findIndex(op.parameters, ["in", "formData"])

src/plugins/validation/semantic-validators/validators/paths.js

@@ -41,7 +41,7 @@ export function validate({ resolvedSpec }) {
   }
 
   each(resolvedSpec.paths, (path, pathName) => {
-    if(!path) {
+    if(!path || !pathName) {
       return
     }
 
@@ -73,7 +73,7 @@ export function validate({ resolvedSpec }) {
     })
 
     each(path, (thing, thingName) => {
-      if(thing.parameters) {
+      if(thing && thing.parameters) {
         availableParameters.push(...thing.parameters.map((param, i) => {
           if(!isObject(param)) {
             return

src/plugins/validation/semantic-validators/validators/schema.js

@@ -16,7 +16,7 @@ export function validate({ resolvedSpec }) {
   if(resolvedSpec.paths) {
     each(resolvedSpec.paths, (path, pathName) => {
       each(path, (op, opName) => {
-        if(op.parameters) {
+        if(op && op.parameters) {
           op.parameters.forEach((parameter, parameterIndex) => {
             if(parameter.in === "body" && parameter.schema) {
               schemas.push({
@@ -26,9 +26,9 @@ export function validate({ resolvedSpec }) {
             }
           })
         }
-        if(op.responses) {
+        if(op && op.responses) {
           each(op.responses, (response, responseName) => {
-            if(response.schema) {
+            if(response && response.schema) {
               schemas.push({
                 schema: response.schema,
                 path: ["paths", pathName, opName, "responses", responseName, "schema"]

src/plugins/validation/semantic-validators/validators/walker.js

@@ -14,6 +14,11 @@ export function validate({ jsSpec }) {
 
   function walk(value, path) {
     let curr = path[path.length - 1]
+
+    if(typeof value !== "object" || value === null) {
+      return
+    }
+
     ///// "type" should always be a string, everywhere.
     if(curr === "type" && ["definitions", "properties"].indexOf(path[path.length - 2]) === -1) {
       if(typeof value !== "string") {
@@ -73,10 +78,6 @@ export function validate({ jsSpec }) {
       }
     }
 
-    if(typeof value !== "object" || value === null) {
-      return
-    }
-
     let keys = Object.keys(value)
 
     if(keys.length) {