Skip to content

Commit af8d009

Browse files
authored
Merge pull request #1559 from shockey/ft/big-spec-performance
Improve performance of big API definitions
2 parents 79092af + 27c260a commit af8d009

File tree

3 files changed

+4
-10
lines changed

3 files changed

+4
-10
lines changed

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@
2323
"deps-license": "license-checker --production --csv --out $npm_package_config_deps_check_dir/licenses.csv && license-checker --development --csv --out $npm_package_config_deps_check_dir/licenses-dev.csv",
2424
"deps-size": "webpack -p --config webpack.check.js --json | webpack-bundle-size-analyzer >| $npm_package_config_deps_check_dir/sizes.txt",
2525
"predev": "npm install",
26-
"dev": "npm-run-all --parallel hot-server open-dev watch",
27-
"hot-server": "webpack-dev-server --host 0.0.0.0 --config webpack-hot-dev-server.config.js --inline --hot --progress",
26+
"dev": "npm-run-all --parallel hot-server open-dev",
27+
"hot-server": "webpack-dev-server --host 0.0.0.0 --config webpack-hot-dev-server.config.js --inline --hot --progress --content-base dev-helpers/",
2828
"open-dev": "sleep 3 && node -e 'require(\"open\")(\"http://localhost:3200\")'",
2929
"open-static": "node -e 'require(\"open\")(\"http://localhost:3001\")'",
3030
"lint": "eslint --cache --ext '.js,.jsx' src test",

src/plugins/validation/helpers.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,7 @@ export function makeValidationWorker() {
3030
source: "semantic"
3131
})
3232
if(validationErrors.length) {
33-
validationErrors.forEach(err => {
34-
if(err) {
35-
errActions.newSpecErr(err)
36-
}
37-
})
33+
errActions.newSpecErrBatch(validationErrors)
3834
}
3935
}).catch(function (e) {
4036
console.error(e)

webpack-hot-dev-server.config.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,14 +38,12 @@ module.exports = require("./make-webpack-config.js")({
3838
chunkFilename: "[id].js"
3939
},
4040

41-
devtool: "eval-source-maps",
41+
devtool: "eval-source-map",
4242
devServer: {
4343
port: 3200,
44-
path: path.join(__dirname, "dev-helpers"),
4544
contentBase: path.join(__dirname, "dev-helpers"),
4645
publicPath: "/",
4746
noInfo: true,
48-
colors: true,
4947
hot: true,
5048
stats: {
5149
colors: true

0 commit comments

Comments
 (0)