fix: don't validate for uniqueness against root parameters (#1745)

* fix: don't validate for uniqueness against root parameters

* remove unused import

Author: shockey

src/plugins/validate-semantic/validators/2and3/parameters.js

@@ -1,43 +1,18 @@
-import { getRootNode } from "src/plugins/validate-semantic/helpers"
-
 export const validate2And3ParametersHaveUniqueNameAndInCombinations = () => (system) => {
   return system.validateSelectors
     .allParameterArrays()
     .then(nodes => {
       return nodes.reduce((acc, node) => {
         const parameters = node.node || []
         const isOperationParameters = system.validateSelectors.isOperationParameters(node)
-        const isPathItemParameters = system.validateSelectors.isPathItemParameters(node)
 
         var inheritedParameters = []
 
         if(isOperationParameters) {
           const pathItemParameters = (node.parent.parent.node.parameters || [])
             .map(preserveOriginalIndices)
 
-          const rootParameterObj = getRootNode(node).node.parameters || {}
-          const rootParameters = Object.keys(rootParameterObj)
-            .map((k, i) => {
-              const obj = rootParameterObj[k]
-              return preserveOriginalIndices(obj, i)
-            })
-
-          inheritedParameters = [
-            ...rootParameters,
-            ...pathItemParameters
-          ]
-        } else if(isPathItemParameters) {
-
-          const rootParameterObj = getRootNode(node).node.parameters || {}
-          const rootParameters = Object.keys(rootParameterObj)
-            .map((k, i) => {
-              const obj = rootParameterObj[k]
-              return preserveOriginalIndices(obj, i)
-            })
-
-          inheritedParameters = [
-            ...rootParameters
-          ]
+          inheritedParameters = [...pathItemParameters]
         } else {
           inheritedParameters = []
         }

test/plugins/validate-semantic/2and3/parameters.js

@@ -176,14 +176,9 @@ describe(`validation plugin - semantic - 2and3 parameters`, () => {
         return validateHelper(spec)
         .then(system => {
           const allErrors = system.errSelectors.allErrors().toJS()
-          expect(allErrors.length).toEqual(2)
+          expect(allErrors.length).toEqual(1)
           const firstError = allErrors[0]
-          const secondError = allErrors[1]
           expect(firstError).toInclude({
-            path: ["paths", "/pets", "parameters", "0"],
-            message: "Sibling parameters, whether inherited or direct, must have unique name + in values"
-          })
-          expect(secondError).toInclude({
             path: ["paths", "/pets", "get", "parameters", "0"],
             message: "Sibling parameters, whether inherited or direct, must have unique name + in values"
           })
@@ -229,20 +224,15 @@ describe(`validation plugin - semantic - 2and3 parameters`, () => {
         return validateHelper(spec)
         .then(system => {
           const allErrors = system.errSelectors.allErrors().toJS()
-          expect(allErrors.length).toEqual(2)
+          expect(allErrors.length).toEqual(1)
           const firstError = allErrors[0]
-          const secondError = allErrors[1]
           expect(firstError).toInclude({
-            path: ["paths", "/pets", "parameters", "0"],
-            message: "Sibling parameters, whether inherited or direct, must have unique name + in values"
-          })
-          expect(secondError).toInclude({
             path: ["paths", "/pets", "get", "parameters", "0"],
             message: "Sibling parameters, whether inherited or direct, must have unique name + in values"
           })
         })
       })
-      it("should return an error for an invalid Swagger 2 definition due to root->operation inheritance", () => {
+      it("should not return an error for root parameters in Swagger 2", () => {
         const spec = {
           swagger: "2.0",
           parameters: {
@@ -274,16 +264,10 @@ describe(`validation plugin - semantic - 2and3 parameters`, () => {
         return validateHelper(spec)
         .then(system => {
           const allErrors = system.errSelectors.allErrors().toJS()
-          expect(allErrors.length).toEqual(1)
-          const firstError = allErrors[0]
-          expect(firstError).toInclude({
-            path: ["paths", "/pets", "get", "parameters", "0"],
-            message: "Sibling parameters, whether inherited or direct, must have unique name + in values"
-          })
-
+          expect(allErrors.length).toEqual(0)
         })
       })
-      it("should return an error for an invalid OpenAPI 3 definition due to root->operation inheritance", () => {
+      it("should not return an error for root parameters in OpenAPI 3", () => {
         const spec = {
           openapi: "3.0.0",
           parameters: {
@@ -315,12 +299,7 @@ describe(`validation plugin - semantic - 2and3 parameters`, () => {
         return validateHelper(spec)
         .then(system => {
           const allErrors = system.errSelectors.allErrors().toJS()
-          expect(allErrors.length).toEqual(1)
-          const firstError = allErrors[0]
-          expect(firstError).toInclude({
-            path: ["paths", "/pets", "get", "parameters", "0"],
-            message: "Sibling parameters, whether inherited or direct, must have unique name + in values"
-          })
+          expect(allErrors.length).toEqual(0)
         })
       })
       it("should return no errors for a valid Swagger 2 definition", () => {