Merge pull request #905 from swagger-api/issue-904

use errors with promises

Author: fehguy

browser/swagger-client.js

@@ -90,7 +90,12 @@ SwaggerHttp.prototype.execute = function (obj, opts) {
   };
 
   obj.on.response = function(data) {
-    responseInterceptor(data);
+    if(data && data.status >= 400) {
+      errorInterceptor(data);
+    }
+    else {
+      responseInterceptor(data);
+    }
   };
 
   if (_.isObject(obj) && _.isObject(obj.body)) {

browser/swagger-client.min.js

@@ -1405,6 +1405,23 @@ describe('SwaggerClient', function () {
     });
   });
 
+  it('should catch an error', function(done) {
+    new SwaggerClient({
+      url: 'http://localhost:8000/v2/issue-716.yaml',
+      usePromise: true
+    }).then(function(client) {
+      client.Data.getPets()
+        .then(function(data) {
+          done('shoulda failed');
+        })
+        .catch(function(err) {
+          done();
+        })
+    }).catch(function(exception) {
+      done(exception);
+    });
+  });
+
   it('should read a blob', function(done) {
     var spec = {
       paths: {

lib/http.js

@@ -102,7 +102,7 @@ exports.petstore = function (arg1, arg2, arg3, arg4) {
 
           return;
         } else {
-          res.writeHead(200, {'Content-Type': 'text/plain'});
+          res.writeHead(404, {'Content-Type': 'text/plain'});
           res.write('404 Not Found\n');
           res.end();
         }

test/client.js

@@ -365,6 +365,12 @@ describe('swagger request functions', function () {
       expect(resp.headers['content-type']).toNotBe(undefined);
       expect(resp.headers['content-type']).toBe('text/plain');
 
+      done('should have failed');
+    }, function(err) {
+      expect(err.headers).toNotBe(undefined);
+      expect(err.headers['content-type']).toNotBe(undefined);
+      expect(err.headers['content-type']).toBe('text/plain');
+
       done();
     });
   });

test/mock.js

@@ -6,6 +6,8 @@ basePath: /
 paths:
   /linked:
     get:
+      tags:
+      - Data
       description: Returns a list of pets
       operationId: getPets
       responses: