Merge pull request #1100 from aaronfullerton/fix-falsy-formatValue

shockey · web-flow · commit 67567174d134 · 2017-07-06T22:50:45.000-07:00
Allow false query parameters
diff --git a/src/http.js b/src/http.js
@@ -144,7 +144,8 @@ function formatValue({value, collectionFormat, allowEmptyValue}, skipEncoding) {
   if (typeof value === 'undefined' && allowEmptyValue) {
     return ''
   }
-  if (isFile(value)) {
+
+  if (isFile(value) || typeof value === 'boolean') {
     return value
   }
 
diff --git a/test/http.js b/test/http.js
@@ -211,11 +211,14 @@ describe('http', () => {
           },
           two: {
             value: 2
+          },
+          three: {
+            value: false
           }
         }
       }
 
-      expect(encodeFormOrQuery(req.query)).toEqual('one=1&two=2')
+      expect(encodeFormOrQuery(req.query)).toEqual('one=1&two=2&three=false')
     })
 
     it('should handle arrays', function () {

Original file line number	Diff line number	Diff line change
`@@ -144,7 +144,8 @@ function formatValue({value, collectionFormat, allowEmptyValue}, skipEncoding) {`
`144`	`144`	`if (typeof value === 'undefined' && allowEmptyValue) {`
`145`	`145`	`return ''`
`146`	`146`	`}`
`147`		`- if (isFile(value)) {`
	`147`	`+`
	`148`	`+ if (isFile(value) \|\| typeof value === 'boolean') {`
`148`	`149`	`return value`
`149`	`150`	`}`
`150`	`151`
Original file line number	Diff line number	Diff line change
`@@ -211,11 +211,14 @@ describe('http', () => {`
`211`	`211`	`},`
`212`	`212`	`two: {`
`213`	`213`	`value: 2`
	`214`	`+ },`
	`215`	`+ three: {`
	`216`	`+ value: false`
`214`	`217`	`}`
`215`	`218`	`}`
`216`	`219`	`}`
`217`	`220`
`218`		`- expect(encodeFormOrQuery(req.query)).toEqual('one=1&two=2')`
	`221`	`+ expect(encodeFormOrQuery(req.query)).toEqual('one=1&two=2&three=false')`
`219`	`222`	`})`
`220`	`223`
`221`	`224`	`it('should handle arrays', function () {`