stringify request.body in #execute (#1034)

* stringify request.body in #execute

and NOT in buildRequest, so as to allow other code to modify the body,
before finally getting processed by execute

* Add another test for non-objects

Author: ponelat

src/execute.js

@@ -1,5 +1,6 @@
 import assign from 'lodash/assign'
 import getIn from 'lodash/get'
+import isObject from 'lodash/isObject'
 import btoa from 'btoa'
 import url from 'url'
 import http, {mergeInQueryOrForm} from './http'
@@ -47,6 +48,10 @@ export function execute({
 
   const request = self.buildRequest({spec, operationId, parameters, securities, ...extras})
 
+  if (request.body && isObject(request.body)) {
+    request.body = JSON.stringify(request.body)
+  }
+
   // Build request and execute it
   return userHttp(request)
 }

test/execute.js

@@ -663,6 +663,28 @@ describe('execute', () => {
         }
       })
     })
+
+    it('should NOT stringify the body, if provided with a javascript object (only execute should do that, allowing us to modify the object in a clean way)', function() {
+
+      // Given
+      const spec = {
+        host: 'swagger.io',
+        paths: {'/me': {post: {parameters: [{name: 'body', in: 'body'}], operationId: 'makeMe'}}}
+      }
+
+      const req = buildRequest({
+        spec,
+        operationId: 'makeMe',
+        parameters: {
+          body: {
+            one: 1,
+          }
+        }})
+
+      expect(req.body).toEqual({
+        one: 1
+      })
+    })
   })
 
   // Note: this is to handle requestContentType and responseContentType
@@ -674,7 +696,7 @@ describe('execute', () => {
       paths: {'/one': {get: {operationId: 'getMe'}}}
     }
 
-    const buildRequestSpy = spyOn(stubs, 'buildRequest')
+    const buildRequestSpy = spyOn(stubs, 'buildRequest').andReturn({})
 
     execute({
       fetch: createSpy().andReturn({then() { }}),
@@ -689,6 +711,55 @@ describe('execute', () => {
     })
   })
 
+  it('should stringify body, if provided with javascript object', function () {
+    // Given
+    const spec = {
+      host: 'swagger.io',
+      paths: {'/me': {post: {parameters: [{name: 'body', in: 'body'}], operationId: 'makeMe'}}}
+    }
+
+    const fetchSpy = createSpy().andReturn({then() { }})
+
+    execute({
+      fetch: fetchSpy,
+      spec,
+      operationId: 'makeMe',
+      parameters: {
+        body: {
+          one: 1,
+          two: {
+            three: 3
+          }
+        }
+      }
+    })
+
+    expect(fetchSpy.calls.length).toEqual(1)
+    expect(fetchSpy.calls[0].arguments[0].body).toEqual('{"one":1,"two":{"three":3}}')
+  })
+
+  it('should NOT stringify body, if its a non-object', function () {
+    // Given
+    const spec = {
+      host: 'swagger.io',
+      paths: {'/me': {post: {parameters: [{name: 'body', in: 'body'}], operationId: 'makeMe'}}}
+    }
+
+    const fetchSpy = createSpy().andReturn({then() { }})
+
+    execute({
+      fetch: fetchSpy,
+      spec,
+      operationId: 'makeMe',
+      parameters: {
+        body: 'hello'
+      }
+    })
+
+    expect(fetchSpy.calls.length).toEqual(1)
+    expect(fetchSpy.calls[0].arguments[0].body).toEqual('hello')
+  })
+
   describe('applySecurities', function () {
     it('should NOT add any securities, if the operation does not require it', function () {
       const spec = {