linting

Author: fehguy

browser/swagger-client.js

@@ -139,7 +139,7 @@ SwaggerClient.prototype.initialize = function (url, options) {
 
   if (options.enableCookies) {
     this.enableCookies = options.enableCookies;
-  };
+  }
 
   this.options = options || {};
 
@@ -452,7 +452,7 @@ SwaggerClient.prototype.makeUniqueOperationId = function(operationId, api) {
       if(operation.nickname === name) {
         matched = true;
       }
-    })
+    });
     if(!matched) {
       return name;
     }
@@ -461,7 +461,7 @@ SwaggerClient.prototype.makeUniqueOperationId = function(operationId, api) {
   }
 
   return operationId;
-}
+};
 
 SwaggerClient.prototype.parseUri = function (uri) {
   var urlParseRE = /^(((([^:\/#\?]+:)?(?:(\/\/)((?:(([^:@\/#\?]+)(?:\:([^:@\/#\?]+))?)@)?(([^:\/#\?\]\[]+|\[[^\/\]@#?]+\])(?:\:([0-9]+))?))?)?)?((\/?(?:[^\/\?#]+\/+)*)([^\?#]*)))?(\?[^#]+)?)(#.*)?/;

browser/swagger-client.min.js

@@ -40,8 +40,8 @@ SwaggerHttp.prototype.execute = function (obj, opts) {
       hasJQuery = true;
     }
   }
-  if(this.isInternetExplorer() && (obj.useJQuery === false || !hasJquery )) {
-    throw new Exception('Unsupported configuration! JQuery is required but not available');
+  if(this.isInternetExplorer() && (obj.useJQuery === false || !hasJQuery )) {
+    throw new Error('Unsupported configuration! JQuery is required but not available');
   }
   if ((obj && obj.useJQuery === true) || this.isInternetExplorer() && hasJQuery) {
     client = new JQueryHttpClient(opts);
@@ -54,7 +54,7 @@ SwaggerHttp.prototype.execute = function (obj, opts) {
       data = opts.requestInterceptor.apply(data);
     }
     return data;
-  }
+  };
 
   var responseInterceptor = function(data) {
     if(opts && opts.responseInterceptor) {
@@ -104,7 +104,7 @@ SwaggerHttp.prototype.isInternetExplorer = function () {
 };
 
 JQueryHttpClient.prototype.execute = function (obj) {
-  var jq = jQuery || window.jQuery;
+  var jq = this.jQuery || window.jQuery;
   var cb = obj.on;
   var request = obj;
 

lib/client.js

@@ -587,7 +587,7 @@ Resolver.prototype.resolveTo = function (root, property, resolutionTable, locati
     this.resolveTo(root, items, resolutionTable, location);
   } else {
     if(property && property.properties) {
-      var name = this.uniqueName("inline_model");
+      var name = this.uniqueName('inline_model');
       this.spec.definitions[name] = _.cloneDeep(property);
       property['$ref'] = '#/definitions/' + name;
       delete property.type;
@@ -606,7 +606,7 @@ Resolver.prototype.uniqueName = function(base) {
     name = base + '_' + count;
     count++;
   }
-}
+};
 
 Resolver.prototype.resolveAllOf = function(spec, obj, depth) {
   depth = depth || 0;
@@ -627,7 +627,7 @@ Resolver.prototype.resolveAllOf = function(spec, obj, depth) {
       var allOf = item.allOf;
       if(_.isArray(allOf)) {
         var output = _.cloneDeep(item);
-        delete output['allOf'];
+        delete output.allOf;
 
         output['x-composed'] = true;
         if (typeof item['x-resolved-from'] !== 'undefined') {

lib/http.js

@@ -305,7 +305,7 @@ describe('converts specs', function () {
           apply: function (requestObj) {
             // rewrites an invalid pet id (-100) to be valid (1)
             // you can do what you want here, like inject headers, etc.
-            callCount += 1
+            callCount += 1;
             return requestObj;
           }
         }
@@ -319,7 +319,7 @@ describe('converts specs', function () {
         var operation = client.apis.pet.operations.getPetById;
         expect(operation.successResponse[200].definition).toBeAn('object');
         expect(operation.responses[400].schema).toBeAn('object');
-        expect(operation.responses[400].schema['$ref']).toBe('#/definitions/VeryBad');
+        expect(operation.responses[400].schema.$ref).toBe('#/definitions/VeryBad');
         expect(callCount).toEqual(4);
         done();
       }).catch(function(e) {

lib/resolver.js

@@ -333,7 +333,7 @@ describe('swagger resolver', function () {
     api.resolve(spec, 'http://localhost:8000/v2/petstore.json', function (spec, unresolved) {
       expect(Object.keys(unresolved).length).toBe(0);
       test.object(spec);
-      var pet = spec.definitions['Pet'];
+      var pet = spec.definitions.Pet;
 
       expect(pet).toBeAn('object');
       expect(pet.discriminator).toBeAn('string');

test/compat/converter.js

@@ -13,7 +13,6 @@ var instance;
 /* jshint ignore:end */
 
 describe('client macros', function () {
-    /* jshint ignore:start */
     before(function (done) {
         mock.petstore(done, function (petstore, server){
             instance = server;

test/composition.js

@@ -33,12 +33,12 @@ var quantityFD = {
   name: 'quantity',
   type: 'integer',
   format: 'int32'
-}
+};
 var nameFD = {
   in: 'formData',
   name: 'name',
   type: 'string'
-}
+};
 
 describe('operations', function () {
   it('should generate a url', function () {

test/macros.js

@@ -959,41 +959,41 @@ describe('swagger resolver', function () {
   it('resolves shared responses', function(done) {
     var api = new Resolver();
     var spec = {
-      "swagger" : "2.0",
-      "info" : {
-        "version" : "0.0.0",
-        "title" : "Simple API"
+      swagger : '2.0',
+      info : {
+        version : '0.0.0',
+        title : 'Simple API'
       },
-      "responses": {
-        "Success": {
-          "description": "Success",
-          "schema": {
-            "type": "string"
+      responses: {
+        Success: {
+          description: 'Success',
+          schema: {
+            type: 'string'
           }
         },
-        "Error": {
-          "description": "Error",
-          "schema": {
-            "type": "string"
+        Error: {
+          description: 'Error',
+          schema: {
+            type: 'string'
           }
         }
       },
-      "paths" : {
-        "/" : {
-          "get" : {
-            "parameters" : [ ],
-            "responses" : {
-              "200" : {
-                "$ref": "#/responses/Success"
+      paths : {
+        '/' : {
+          get : {
+            parameters : [ ],
+            responses : {
+              200 : {
+                $ref: '#/responses/Success'
               },
-              "default": {
-                "$ref": "#/responses/Error"
+              default: {
+                $ref: '#/responses/Error'
               }
             }
           }
         }
       },
-      "definitions" : { }
+      definitions : { }
     };
     api.resolve(spec, 'http://localhost:8000/v2/swagger.json', function (spec, unresolved) {
       var responses = spec.paths['/'].get.responses;