Merge pull request #930 from swagger-api/issue-929

type checks, tests for #929

Author: fehguy

browser/swagger-client.js

@@ -211,7 +211,7 @@ SwaggerClient.prototype.build = function (mock) {
     },
     on: {
       error: function (response) {
-        if (self.url.substring(0, 4) !== 'http') {
+        if (self && self.url && self.url.substring(0, 4) !== 'http') {
           return self.fail('Please specify the protocol for ' + self.url);
         } else if (response.errObj && (response.errObj.code === 'ECONNABORTED' || response.errObj.message.indexOf('timeout') !== -1)) {
           return self.fail('Request timed out after ' + self.fetchSpecTimeout + 'ms');
@@ -259,7 +259,7 @@ SwaggerClient.prototype.build = function (mock) {
     obj.timeout = this.fetchSpecTimeout;
   }
 
-  if (this.spec) {
+  if (this.spec && typeof this.spec === 'object') {
     self.swaggerObject = this.spec;
     setTimeout(function () {
       new Resolver().resolve(self.spec, self.url, self.buildFromSpec, self);

browser/swagger-client.min.js

@@ -8,7 +8,7 @@
     }
   ],
   "description": "swagger-client is a javascript client for use with swaggering APIs.",
-  "version": "2.1.29",
+  "version": "2.1.30",
   "homepage": "http://swagger.io",
   "repository": {
     "type": "git",

lib/client.js

@@ -0,0 +1,55 @@
+/* global after, before, describe, it */
+
+'use strict';
+
+var expect = require('expect');
+var test = require('unit.js');
+var SwaggerClient = require('..');
+
+var petstoreRaw = require('./spec/v2/petstore.json');
+
+
+describe('swagger resolver', function () {
+  it('fails gracefully with bad spec', function(done) {
+    new SwaggerClient({
+      spec: 'bad',
+      usePromise: true
+    }).then(function(client) {
+      done('should have failed');
+    }).catch(function(err) {
+      done();
+    })
+  });
+
+  it('fails gracefully with bad URL', function(done) {
+    new SwaggerClient({
+      url: 'http://fake.fake/swagger.json',
+      usePromise: true
+    }).then(function(client) {
+      done('should have failed');
+    }).catch(function(err) {
+      done();
+    })
+  });
+
+  it('fails gracefully with operation', function(done) {
+    new SwaggerClient({
+      spec: petstoreRaw,
+      usePromise: true
+    }).then(function(client) {
+      client.pet.getPetById({petId: 3})
+        .then(function(data) {
+          console.log('ok')
+          console.log(data);
+          done('should have failed');
+        })
+        .catch(function(error) {
+          console.log('error')
+          console.log(error);
+          done();
+        })
+    }).catch(function(err) {
+      done('should have failed');
+    })
+  }); 
+});