improvement: use JSON.parse method for all types and encodings of json (via #1419)

extempl · shockey · commit cf0b0380b1b4 · 2019-02-02T00:06:07.000-06:00
* Use `JSON.parse` method for all types and encodings of `json`

* Fix case when `contentType` is `undefined`
diff --git a/src/http.js b/src/http.js
@@ -69,7 +69,7 @@ export default async function http(url, request = {}) {
 export const shouldDownloadAsText = (contentType = '') => /(json|xml|yaml|text)\b/.test(contentType)
 
 function parseBody(body, contentType) {
-  if (contentType === 'application/json') {
+  if (contentType && (contentType.indexOf('application/json') === 0 || contentType.indexOf('+json') > 0)) {
     return JSON.parse(body)
   }
   return jsYaml.safeLoad(body)

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ export default async function http(url, request = {}) {`
`69`	`69`	`export const shouldDownloadAsText = (contentType = '') => /(json\|xml\|yaml\|text)\b/.test(contentType)`
`70`	`70`
`71`	`71`	`function parseBody(body, contentType) {`
`72`		`- if (contentType === 'application/json') {`
	`72`	`+ if (contentType && (contentType.indexOf('application/json') === 0 \|\| contentType.indexOf('+json') > 0)) {`
`73`	`73`	`return JSON.parse(body)`
`74`	`74`	`}`
`75`	`75`	`return jsYaml.safeLoad(body)`