Add warning for JSON Pointers that lack a leading /

Author: shockey

src/specmap/lib/refs.js

@@ -55,6 +55,10 @@ const plugin = {
     const refPath = splitString[0]
     const pointer = splitString[1] || ''
 
+    if (pointer.length > 0 && pointer[0] !== '/') {
+      console.warn(`WARNING: $ref '${ref}' is malformed, a leading '/' is expected after '#'`)
+    }
+
     let basePath
     try {
       basePath = (baseDoc || refPath) ? absoluteify(refPath, baseDoc) : null

test/specmap/index.js

@@ -1,4 +1,4 @@
-import expect from 'expect'
+import expect, {createSpy} from 'expect'
 import clone from 'clone'
 import xmock from 'xmock'
 import traverse from 'traverse'
@@ -419,6 +419,23 @@ describe('specmap', function () {
             })
         })
 
+        it('should warn about malformed JSON Pointers', function () {
+          // for https://github.com/swagger-api/swagger-editor/issues/1560
+          const oriWarn = console.warn
+          console.warn = createSpy().andCallThrough()
+          return mapSpec({
+            spec: {
+              nested: {one: 1},
+              another: {$ref: '#nested'}
+            },
+            plugins: [plugins.refs]
+          })
+            .then((res) => {
+              console.warn = oriWarn
+              expect(console.warn).toHaveBeenCalledWith('WARNING: $ref \'http://example.com/doc-a#two\' is malformed, a leading \'/\' is expected after \'#\'')
+            })
+        })
+
         it('should resolve internal $refs in arrays', function () {
           return mapSpec({
             spec: {