housekeeping: add passing nested resolver tests (via #1406)

* housekeeping: add passing nested resolver tests
* linter fixes

Author: shockey

test/client.js

@@ -2,6 +2,7 @@ import http from 'http'
 import url from 'url'
 import path from 'path'
 import fs from 'fs'
+import {createSpy} from 'expect'
 
 import Swagger from '../src/index'
 
@@ -280,7 +281,38 @@ describe('http', () => {
         return req
       }
     }).catch((err) => {
-      expect(err.message).toEqual('request to https://localhost:8000/petstore.json failed, reason: socket hang up')
+      expect(err.message).toEqual(
+        'request to https://localhost:8000/petstore.json failed, reason: socket hang up'
+      )
+    })
+  })
+
+  test('should use requestInterceptor for resolving nested $refs', () => {
+    const requestInterceptor = createSpy().andCallThrough(req => req)
+    return Swagger({
+      url: 'http://localhost:8000/nested/one.yaml',
+      requestInterceptor
+    }).then((client) => {
+      expect(requestInterceptor.calls.length).toEqual(3)
+      expect(requestInterceptor.calls[0].arguments[0].url).toEqual('http://localhost:8000/nested/one.yaml')
+      expect(requestInterceptor.calls[1].arguments[0].url).toEqual('http://localhost:8000/nested/two.yaml')
+      expect(requestInterceptor.calls[2].arguments[0].url).toEqual('http://localhost:8000/nested/three.yaml')
+
+      expect(client.spec).toEqual({
+        data: {
+          value: 'one!',
+          nested: {
+            $$ref: './two.yaml',
+            data: {
+              value: 'two!',
+              nested: {
+                $$ref: './three.yaml',
+                value: 'three!'
+              }
+            }
+          }
+        }
+      })
     })
   })
 })

test/data/nested/one.yaml

@@ -0,0 +1,4 @@
+data:
+  value: one!
+  nested:
+    $ref: "./two.yaml"

test/data/nested/three.yaml

@@ -0,0 +1 @@
+value: three!

test/data/nested/two.yaml

@@ -0,0 +1,4 @@
+data:
+  value: two!
+  nested:
+    $ref: "./three.yaml"

test/subtree-resolver.js

@@ -1,4 +1,5 @@
 import xmock from 'xmock'
+import {createSpy} from 'expect'
 import resolve from '../src/subtree-resolver'
 
 describe('subtree $ref resolver', () => {
@@ -722,4 +723,76 @@ describe('subtree $ref resolver', () => {
       }
     })
   })
+  test.only('should redirect and resolve nested remote document requests', async () => {
+    const input = {
+      foo: {
+        bar: {
+          $ref: './fake-remote.json'
+        }
+      }
+    }
+
+    const requestInterceptor = createSpy((req) => {
+      req.headers.authorization = 'wow'
+
+      if (req.url === 'http://example.com/fake-remote.json') {
+        req.url = 'http://example.com/remote.json'
+      }
+      if (req.url === 'http://example.com/fake-nested.json') {
+        req.url = 'http://example.com/nested.json'
+      }
+      return req
+    }).andCallThrough()
+
+    xmock()
+      .get('http://example.com/remote.json', function (req, res, next) {
+        if (req.header.authorization !== 'wow') {
+          res.status(403)
+        }
+        res.send({
+          baz: {
+            $ref: '#/remoteOther'
+          },
+          remoteOther: {
+            $ref: './fake-nested.json'
+          }
+        })
+      })
+      .get('http://example.com/nested.json', function (req, res, next) {
+        if (req.header.authorization !== 'wow') {
+          res.status(403)
+        }
+        res.send({
+          result: 'it works!'
+        })
+      })
+
+    const res = await resolve(input, [], {
+      baseDoc: 'http://example.com/main.json',
+      requestInterceptor
+    })
+
+    expect(requestInterceptor.calls.length).toEqual(2)
+    expect(requestInterceptor.calls[0].arguments[0].url).toEqual('http://example.com/remote.json')
+    expect(requestInterceptor.calls[1].arguments[0].url).toEqual('http://example.com/nested.json')
+
+    expect(res).toEqual({
+      errors: [],
+      spec: {
+        foo: {
+          bar: {
+            $$ref: './fake-remote.json',
+            baz: {
+              $$ref: './fake-nested.json',
+              result: 'it works!'
+            },
+            remoteOther: {
+              $$ref: './fake-nested.json',
+              result: 'it works!'
+            }
+          }
+        }
+      }
+    })
+  })
 })