Merge pull request #893 from r-sreesaran/branch_test

added fix for issue 889

Author: gracekarina

modules/swagger-parser-v3/src/main/java/io/swagger/v3/parser/util/OpenAPIDeserializer.java

@@ -293,11 +293,18 @@ public List<Tag> getTagList(ArrayNode obj, String location, ParseResult result)
             return null;
         }
         List<Tag> tags = new ArrayList<>();
+        Set<String> tagsTracker = new HashSet<>();
         for (JsonNode item : obj) {
             if (item.getNodeType().equals(JsonNodeType.OBJECT)) {
                 Tag tag = getTag((ObjectNode) item, location, result);
                 if (tag != null) {
                     tags.add(tag);
+
+                    if(tagsTracker.contains((String)tag.getName())) {
+                        result.uniqueTags(location,tag.getName());
+                    }
+
+                    tagsTracker.add(tag.getName());
                 }
             }
         }
@@ -2676,6 +2683,7 @@ protected static class ParseResult {
         private Map<Location, String> invalidType = new LinkedHashMap<>();
         private List<Location> missing = new ArrayList<>();
         private List<Location> unique = new ArrayList<>();
+        private List<Location> uniqueTags = new ArrayList<>();
 
         public ParseResult() {
         }
@@ -2696,6 +2704,8 @@ public void unique(String location, String key) {
             unique.add(new Location(location, key));
         }
 
+        public void uniqueTags(String location, String key) {uniqueTags.add(new Location(location,key));}
+
         public void invalidType(String location, String key, String expectedType, JsonNode value) {
             invalidType.put(new Location(location, key), expectedType);
         }
@@ -2735,6 +2745,11 @@ public List<String> getMessages() {
                 String message = "attribute " + location + l.key + " is repeated";
                 messages.add(message);
             }
+            for (Location l : uniqueTags) {
+                String location = l.location.equals("") ? "" : l.location + ".";
+                String message = "attribute " + location + l.key + " is repeated";
+                messages.add(message);
+            }
             return messages;
         }
     }

modules/swagger-parser/src/test/java/io/swagger/parser/OpenAPIParserTest.java

@@ -64,6 +64,17 @@ public void testSimple() {
         assertEquals(result.getOpenAPI().getOpenapi(), "3.0.1");
     }
 
+
+    @Test
+    public void testIssue887() {
+        ParseOptions options = new ParseOptions();
+        SwaggerParseResult result = new OpenAPIParser().readLocation("apiWithMultipleTags.json", null, null);
+        System.out.println(result.getMessages());
+        assertNotNull(result);
+        assertNotNull(result.getOpenAPI());
+        assertEquals(result.getMessages().get(0), "attribute tags.sample is repeated");
+    }
+
     @Test
     public void testIssue768() {
         ParseOptions options = new ParseOptions();

modules/swagger-parser/src/test/resources/apiWithMultipleTags.json

@@ -0,0 +1,142 @@
+{
+    "openapi": "3.0.0",
+    "info": {
+      "title": "Sample API",
+      "description": "Optional multiline or single-line description in [CommonMark](http://commonmark.org/help/) or HTML.",
+      "version": "0.1.9"
+    },
+    "servers": [
+      {
+        "url": "http://localhost:5555/rest/RestNativeService",
+        "description": "a service that accepts anything"
+      }
+    ],
+    "tags":[
+        {"name":"sample"},
+        {"name":"sample"}
+        ],
+    "paths": {
+      "/getTimeAfterJson/{time}": {
+        "post": {
+          
+          "security" : [{"OpenID":["read"]}],
+          "parameters": [
+            {
+              "in": "path",
+              "name": "time",
+              "content": {
+                "application/json": {
+                  "schema": {
+                    "type": "integer"
+                    
+                  }
+                }
+              }
+            },
+            
+            {
+              "in": "cookie",
+              "name": "debug",
+              "schema": {
+                "type": "integer",
+                "enum": [
+                  0,
+                  1
+                ],
+                "default": 0
+              },
+              "required":true
+            },
+            {
+              "in": "cookie",
+              "name": "csrftoken",
+              "schema": {
+                "type": "string"
+              },
+              "required":true
+            }            
+          ],
+          "requestBody": {
+            "content": {
+              "application/json": {
+                "schema": {
+                  "allOf": [
+                    {
+                      "$ref": "#/components/schemas/temp"
+                    },
+                    {
+                      "$ref": "#/components/schemas/temp1"
+                    }
+                  ]
+                }
+              }
+            }
+          },
+          "responses": {
+            "200": {
+              "description": "Updated"
+            }
+          }
+        }
+      }
+    },
+    "components": {
+      "securitySchemes":{
+        "BasicAuth": {
+        "type": "http",
+        "scheme": "basic"
+      },
+      "BearerAuth": {
+        "type": "http",
+        "scheme": "bearer"
+      },
+      "ApiKeyAuth": {
+        "type": "apiKey",
+        "in": "header",
+        "name": "X-API-Key"
+      },
+      "OAuth2": {
+        "type": "oauth2",
+        "flows": {
+          "authorizationCode": {
+            "refreshUrl":"http://localhost:555",
+            "authorizationUrl": "https://example.com/oauth/authorize",
+            "tokenUrl": "https://example.com/oauth/token",
+            "scopes": {
+              "read": "Grants read access",
+              "write": "Grants write access",
+              "admin": "Grants access to admin operations"
+            }
+          }
+        }
+      }
+      },
+      "schemas": {
+        "temp": {
+          "type": "object",
+          "properties": {
+            "bool1": {
+              "type": "boolean"
+            },
+            "timetype": {
+              "type": "string",
+              "enum": [
+                "nanoseconds",
+                "milliseconds"
+              ]
+            }
+          },
+          "required":["bool1","timetype"]
+        },
+        "temp1": {
+          "properties":{
+              "int":{
+                "type": "integer"
+              }
+          }
+          
+        }
+      }
+    
+    }
+  }