Merge pull request #1710 from swagger-api/issue1643

set validate internal ref option to true by default

Author: gracekarina

modules/swagger-parser-core/src/main/java/io/swagger/v3/parser/core/models/ParseOptions.java

@@ -10,7 +10,7 @@ public class ParseOptions {
     private boolean skipMatches;
     private boolean allowEmptyStrings = true;
     private boolean validateExternalRefs = false;
-    private boolean validateInternalRefs = false;
+    private boolean validateInternalRefs = true;
     private boolean legacyYamlDeserialization = false;
 
     public boolean isResolve() {

modules/swagger-parser-v3/src/test/java/io/swagger/v3/parser/test/OpenAPIV3ParserTest.java

@@ -88,7 +88,6 @@ public class OpenAPIV3ParserTest {
     @Test
     public void testIssue1643_True() throws Exception{
         ParseOptions options = new ParseOptions();
-        options.setValidateInternalRefs(true);
         String issue1643 = "openapi: \"3.0.0\"\n" +
                 "info:\n" +
                 "  version: 1.0.0\n" +
@@ -132,6 +131,7 @@ public void testIssue1643_True() throws Exception{
     @Test
     public void testIssue1643_False() throws Exception{
         ParseOptions options = new ParseOptions();
+        options.setValidateInternalRefs(false);
         String issue1643 = "openapi: \"3.0.0\"\n" +
                 "info:\n" +
                 "  version: 1.0.0\n" +
@@ -370,6 +370,7 @@ public void testCantReadDeepProperties() {
         OpenAPIV3Parser parser = new OpenAPIV3Parser();
         ParseOptions options = new ParseOptions();
         options.setResolveFully(true);
+        options.setValidateInternalRefs(false);
 
         final SwaggerParseResult parseResult = parser.readLocation("src/test/resources/cant-read-deep-properties.yaml", null, options);
         assertEquals(parseResult.getMessages().size(), 0);
@@ -2552,6 +2553,7 @@ public void testIssue915() {
     public void testIssue931() {
         ParseOptions options = new ParseOptions();
         options.setResolve(true);
+        options.setValidateInternalRefs(false);
         SwaggerParseResult result = new OpenAPIV3Parser().readLocation("Issue_931.json", null, options);
         assertNotNull(result.getOpenAPI());
         assertTrue(result.getMessages().size() > 0);